Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot log into player using passwords with certain characters #161

Open
vectorjohn opened this issue Feb 3, 2022 · 9 comments
Open

Cannot log into player using passwords with certain characters #161

vectorjohn opened this issue Feb 3, 2022 · 9 comments

Comments

@vectorjohn
Copy link

vectorjohn commented Feb 3, 2022

Operating system

Linux

Browser name and version

Firefox 96, Chrome

Expected behavior

I can log into the player with the same email+password as my account following whatever password rules account creation enforces.

Actual behavior

I can log into my account but not the player when I use certain (unknown) characters in my password. On the player, I get the error message "If you just signed up or changed your password, please try again in a few seconds…" even if I wait hours.
The server response is an HTTP 400 with the payload {"message":"Unauthorized","status":400}
This is the same response as simply using the wrong password (e.g. asdf).
The problem is not related to JSON encoding on the client side, the POST request is correctly JSON encoded (and decodes correctly too).

Steps to reproduce behavior

  1. Create new account ate resonate.is as a listener. Use the password K^d`c(+zP"jkU/_.,E<7
  2. Log out, log back into account to verify password works.
  3. Click Listen (opens the player).
  4. enter email+password from step 1

I'm not really concerned with what the password rules are, but they need to be consistent between the account and player. As a new user, I created an account and immediately could not log in to the one thing I actually wanted. I tried waiting, I reset my password, nothing worked.
Once I started doing QA I created accounts with various email addresses until I tried generating a simpler alphanumeric password. It was the password causing the problem, when I stuck to letters and numbers, the problem went away and I could log in.

@fgblomqvist
Copy link
Contributor

Sounds like this: https://community.resonate.is/t/login-issue-on-website-since-ive-created-an-account/2066/5?u=fgblomqvist
Not sure if issues like this is a priority since the new back-end should be out in the "near" future I'm guessing, and probably won't have this issue? @auggod

@vectorjohn
Copy link
Author

Yes, that looks like it. Sorry I didn't find that issue. Although, one commenter seems to indicate a shorter password helped. I can confirm that was not my problem, my password is 32 characters alphanumeric, and it works (and someone in a linked issue here used 64 characters). The issue was the various kinds of quotes I had in it.

@fgblomqvist
Copy link
Contributor

All good. I'm sure it's just the special chars (like you've said) that is the issue.

@hakanto
Copy link

hakanto commented Feb 6, 2022

May not be related, but this week @auggod discovered a bug in the initial account setup and fixed it. In general, login functionality should be much improved. Although I believe certain special characters, in particular ' " are still not allowed.

Appreciate both of y'alls attention on this! 🙏

@AbraGanz
Copy link

I used a simple alphanumeric password to set up my account with no special symbols, but also have this problem. Whenever I try to login nothing happens, and I am simply redirected to the player page without having been logged in.

@vectorjohn
Copy link
Author

That sounds like a different problem from me and the one I split this from. This ticket is explicitly about the non-alphanumeric passwords. I'm no authority but it seems like you should create a new ticket.

@fgblomqvist
Copy link
Contributor

It sounds like @AbraGanz's issue is similar to the original one perhaps: #151

@auggod
Copy link
Member

auggod commented Feb 17, 2022

We're using this golang library to verify hashes from wordpress. I always have suspected this is the issue.
https://github.com/apokalyptik/phpass

@iMartyn
Copy link

iMartyn commented Mar 4, 2022

One of the main issues here is the poor UX if you have rejected cookies. I also struggled for days with this flow (and I'm a devops-type person, not an average joe). The flow goes something like this :

  • Create account
  • Attempt to log in, find you have to log in again, log in again
  • "To listen to the full track you must log in", okay, I'll log in a third time... accepts password fine, "To listen to the full track, you must log in"...
  • Hmm... maybe it's because I'm an artist and require a separate listener account? Same flow, same loop.
  • Start googling, find it might be the password complexity. Reset password to all alphanumeric. Still same loop.
  • eventually, clear local storage that says deny cookies, log in, suddenly it works.

IMO this is a fairly cut and dried case of the login cookie should be an "Essential" cookie, and therefore "deny cookies" should be "deny non-essential cookies" and also the messaging should be clearer, like "Enable cookies(hyperlink to the choice window) and login to listen to the full song".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants