Switch standard to eslint (with standard config) (#174)

* Add base eslintrc

* Add deps

* Update pre-commit hook

* Update all scripts

* Update docs

* Fix lint

Author: fgblomqvist

.eslintrc.js

@@ -0,0 +1,11 @@
+module.exports = {
+  extends: [
+    'standard'
+  ],
+  ignorePatterns: ['**/dist/**'],
+  env: {
+    browser: true,
+    es2021: true,
+    node: true
+  }
+}

.pre-commit-config.yaml

@@ -1,5 +1,5 @@
 repos:
-- repo: https://github.com/standard/standard
-  rev: v16.0.3
-  hooks:
-    - id: standard
+  - repo: https://github.com/pre-commit/mirrors-eslint
+    rev: v7.32.0
+    hooks:
+      - id: eslint

README.md

@@ -199,7 +199,7 @@ npm run build --workspace "@resonate/rangeslider"
 
 ## Testing
 
-Run all tests (standard, dependency-check)
+Run all tests (lint, dependency-check)
 
 ```sh
 npm test
@@ -227,8 +227,9 @@ Command                 | Description                                      |
 
 ## Code style
 
-We use [standard](https://standardjs.com/) as a linter and javascript style guide.
-Make sure to add appropriate plugin for your editor (see: [standard#are-there-text-editor-plugins](https://github.com/standard/standard#are-there-text-editor-plugins)) or install a [pre-commit hook](https://standardjs.com/#use-a-pre-commit-hook) (see `.pre-commit-config.yaml`) to automatically apply the standard style.
+We use [eslint](https://eslint.org/) together with the [standard](https://standardjs.com/) config as a linter and javascript style guide.
+Make sure to add appropriate plugin for your editor, unless it is already supported out-of-box.
+It can also be handy to install the [pre-commit hook](https://pre-commit.com/) (see `.pre-commit-config.yaml`) to automatically apply the standard style.
 
 ## Maintainers
 

beta/package.json

@@ -8,7 +8,8 @@
     "dev": "cd src && jalla start index.js --watch --sw sw.js",
     "audit:npm": "npm audit",
     "start": "NODE_ENV=production jalla serve index.js --dir dist --sw sw.js",
-    "test": "standard && npm run test:deps",
+    "test": "run-s test:lint test:deps",
+    "test:lint": "eslint .",
     "test:deps": "dependency-check ./src/index.js -i @resonate/tachyons --no-dev",
     "test:browser": "browserify src/test/browser/index.js | tape-run | tap-format-spec"
   },
@@ -46,11 +47,6 @@
       "postcss-custom-media": {}
     }
   },
-  "standard": {
-    "ignore": [
-      "/dist/**/*.js"
-    ]
-  },
   "license": "GPL-3.0-or-later",
   "dependencies": {
     "@resonate/api-factory-generator": "*",

beta/src/components/topup-credits/index.js

@@ -113,11 +113,11 @@ class Credits extends Component {
       try {
         const response = this.local.intent
           ? await state.api.payments.updateIntent({
-              uid: state.user.uid,
-              pi: this.local.intent.id,
-              tokens: this.local.data.tokens,
-              currency: this.local.currency
-            })
+            uid: state.user.uid,
+            pi: this.local.intent.id,
+            tokens: this.local.data.tokens,
+            currency: this.local.currency
+          })
           : await state.api.payments.createIntent({
             uid: state.user.uid,
             tokens: this.local.data.tokens,

embed/package.json

@@ -4,13 +4,13 @@
   "private": true,
   "scripts": {
     "build": "NODE_ENV=production jalla build index.js --dir dist --base /embed",
-    "inspect": "jalla inspect index.js",
     "start": "NODE_ENV=production jalla serve index.js --dir dist --base /embed",
     "dev": "jalla index.js --base /embed",
     "audit:npm": "npm audit",
-    "test": "standard && npm run test-deps",
-    "test-browser": "browserify -t [babelify] test/browser/index.js | tape-run --port 5000 --keep-open | tap-format-spec",
-    "test-deps": "dependency-check . -i @resonate/tachyons --no-dev"
+    "test": "run-s test:lint test:deps",
+    "test:lint": "eslint .",
+    "test:browser": "browserify -t [babelify] test/browser/index.js | tape-run --port 5000 --keep-open | tap-format-spec",
+    "test:deps": "dependency-check . -i @resonate/tachyons --no-dev"
   },
   "browser": {
     "assert": "nanoassert"
@@ -48,11 +48,6 @@
       "postcss-custom-media": {}
     }
   },
-  "standard": {
-    "ignore": [
-      "/dist/**/*.js"
-    ]
-  },
   "license": "gpl3",
   "dependencies": {
     "@resonate/api-factory-generator": "*",

package.json

@@ -17,11 +17,6 @@
     "embed",
     "beta"
   ],
-  "standard": {
-    "ignore": [
-      "**/lib/**"
-    ]
-  },
   "dependencies": {
     "@babel/core": "^7.15.8",
     "@babel/node": "^7.15.8",
@@ -37,9 +32,12 @@
     "postcss-nested": "^4.1.2",
     "postcss-preset-env": "^6.6.0",
     "postcss-reporter": "^6.0.1",
-    "sheetify-postcss": "^2.0.0",
-    "standard": "^16.0.4",
     "tape": "^5.3.1",
     "tape-run": "^9.0.0"
+  },
+  "devDependencies": {
+    "eslint": "^7.32.0",
+    "eslint-config-standard": "^16.0.3",
+    "npm-run-all": "^4.1.5"
   }
 }

packages/api-factory-generator/package.json

@@ -7,7 +7,7 @@
     "test": "test"
   },
   "scripts": {
-    "test": "standard && dependency-check .",
+    "test": "eslint . && dependency-check .",
     "test:browser": "browserify -t [babelify] test/index.js | tape-run --port 5000 --keep-open | tap-format-spec"
   },
   "keywords": [

packages/api-service/package.json

@@ -4,7 +4,7 @@
   "description": "API Service Swagger Client Loader",
   "main": "index.js",
   "scripts": {
-    "test": "standard && dependency-check ."
+    "test": "eslint . && dependency-check ."
   },
   "keywords": [
     "api",

packages/artwork-component/package.json

@@ -4,7 +4,7 @@
   "description": "Artwork component",
   "main": "index.js",
   "scripts": {
-    "test": "standard && dependency-check ."
+    "test": "eslint . && dependency-check ."
   },
   "keywords": [
     "nanocomponent"