Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require Omnitone without relative paths #17

Open
brianchirls opened this issue Sep 7, 2018 · 1 comment
Open

require Omnitone without relative paths #17

brianchirls opened this issue Sep 7, 2018 · 1 comment

Comments

@brianchirls
Copy link

The only referenced external dependency is Omnitone, which is imported via a relative path pointing to the library under node_modules as:

const Omnitone = require('../node_modules/omnitone/build/omnitone.js');

Since Omnitone is compiled into this library's build file (which is probably fine), anyone using resonance who also might want to use Omnitone would be forced to load two copies of it. One might try to reference the resonance source files, which are included in the npm package, but since Omnitone is included as above, that won't solve the problem.

Please change this to:

const Omnitone = require('omnitone');

Since you're building with webpack, this should allow builds that use the source files to use their own copy of Omnitone, without changing the build output from this repo. It should also allow dependents to use the latest version of Omnitone without having to wait for an upgrade in this repo.

Thanks

@hoch hoch added the bug label Oct 18, 2018
@hoch
Copy link
Collaborator

hoch commented Oct 18, 2018

I think this might be the case where RA used a modified version of Omnitone, so importing it from the local package was necessary. (while @drewbitllama and I were hacking the code to make HOA work) I think we're past the development phase, so it makes sense to update the dependency as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants