You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since Omnitone is compiled into this library's build file (which is probably fine), anyone using resonance who also might want to use Omnitone would be forced to load two copies of it. One might try to reference the resonance source files, which are included in the npm package, but since Omnitone is included as above, that won't solve the problem.
Please change this to:
constOmnitone=require('omnitone');
Since you're building with webpack, this should allow builds that use the source files to use their own copy of Omnitone, without changing the build output from this repo. It should also allow dependents to use the latest version of Omnitone without having to wait for an upgrade in this repo.
Thanks
The text was updated successfully, but these errors were encountered:
I think this might be the case where RA used a modified version of Omnitone, so importing it from the local package was necessary. (while @drewbitllama and I were hacking the code to make HOA work) I think we're past the development phase, so it makes sense to update the dependency as you suggested.
The only referenced external dependency is Omnitone, which is imported via a relative path pointing to the library under node_modules as:
Since Omnitone is compiled into this library's build file (which is probably fine), anyone using resonance who also might want to use Omnitone would be forced to load two copies of it. One might try to reference the resonance source files, which are included in the npm package, but since Omnitone is included as above, that won't solve the problem.
Please change this to:
Since you're building with webpack, this should allow builds that use the source files to use their own copy of Omnitone, without changing the build output from this repo. It should also allow dependents to use the latest version of Omnitone without having to wait for an upgrade in this repo.
Thanks
The text was updated successfully, but these errors were encountered: