fix: add getChainId to abstract wallet client #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some libraries, notably ReservoirKit use the existence of getChainId to detect the presence of a wallet client. AbstractWalletActions extends
Eip712WalletActions
, NOT viem'sWalletActions
, and therefore does not have thegetChainId
method.This PR adds this method, which should also resolve errors when attempting to use abstract wallet with reservoirkit.
Fixes reservoirprotocol/reservoir-kit#827
Commits
PR-Codex overview
This PR focuses on adding a
getChainId
method to theabstract wallet client
, enhancing its functionality by allowing it to retrieve the chain ID.Detailed summary
getChainId
method to theAbstractWalletActions
type.getChainId
in theglobalWalletActions
function to call thegetChainId
function fromviem/actions
.