Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: initial feedback and questions #11

Merged
merged 15 commits into from
Jun 20, 2024
Merged

review: initial feedback and questions #11

merged 15 commits into from
Jun 20, 2024
+221 −154

Conversation

OliverNChalk
Copy link
Contributor

@OliverNChalk OliverNChalk commented Jun 13, 2024 •
edited
Loading

Was unable to run the tests but here is my initial feedback/thoughts.

@OliverNChalk OliverNChalk merged commit 26353de into dev Jun 20, 2024
5 checks passed
@OliverNChalk OliverNChalk deleted the review/oliver branch June 20, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenide xenide xenide left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OliverNChalk @xenide