Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Storybook examples are busted #85

Closed
bryandowning opened this issue Feb 5, 2020 · 1 comment · Fixed by #86
Closed

All Storybook examples are busted #85

bryandowning opened this issue Feb 5, 2020 · 1 comment · Fixed by #86
Labels
released

Comments

@bryandowning
Copy link
Contributor

Expected behavior

All examples at https://researchgate.github.io/react-intersection-observer/ should load without errors.

Current behavior

There's a TypeError that prevents any of the examples from loading properly.

Cannot read property 'theme' of undefined

Screen Shot 2020-02-05 at 1 39 30 PM

Steps to reproduce

  1. Go to https://researchgate.github.io/react-intersection-observer/

or

  1. Clone this repo
  2. Run yarn
  3. Run yarn storybook

Context (environment)

This appears to have been caused by a package update. There are a couple of relevant issues in the storybook-readme repo: tuchk4/storybook-readme#221 and tuchk4/storybook-readme#220
@bryandowning bryandowning mentioned this issue Feb 5, 2020
Merged
9 tasks
@danez danez closed this as completed in #86 Feb 6, 2020
@Rendez
Copy link
Contributor

Rendez commented Mar 24, 2020

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Storybook): Add empty theme option bryandowning/react-intersection-observer
2 participants
@Rendez @bryandowning