Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hook failure not detected #352

Open
mitchjust-finocomp opened this issue Aug 6, 2021 · 0 comments
Open

pre-commit hook failure not detected #352

mitchjust-finocomp opened this issue Aug 6, 2021 · 0 comments

Comments

@mitchjust-finocomp
Copy link

mitchjust-finocomp commented Aug 6, 2021

When running a release, if a pre-commit hook fails, it does not appear to be detected, and the plugin continues on to try to push:


11:15:22     :commitNewVersion
11:15:22       Running [git, commit, -m, [Gradle Release Plugin] - new version commit:  '0.8.0-SNAPSHOT'., -a] in [/root/build-agent/work/72c58cfb9dcd0768]
11:15:22       Running [git, commit, -m, [Gradle Release Plugin] - new version commit:  '0.8.0-SNAPSHOT'., -a] produced output: []
11:15:22       Running [git, commit, -m, [Gradle Release Plugin] - new version commit:  '0.8.0-SNAPSHOT'., -a] produced an error: [lint-staged requires at least version 12.13.0 of Node, please upgrade
11:15:22       husky - pre-commit hook exited with code 1 (error)]
11:15:22       Running [git, remote] in [/root/build-agent/work/72c58cfb9dcd0768]
11:15:22       Running [git, remote] produced output: [origin]
11:15:22       Running [git, branch, --no-color] in [/root/build-agent/work/72c58cfb9dcd0768]
11:15:22       Running [git, branch, --no-color] produced output: [* master]
11:15:22       Running [git, push, --porcelain, origin, master] in [/root/build-agent/work/72c58cfb9dcd0768]
11:15:23       Running [git, push, --porcelain, origin, master] produced output: [To gitlab.com:bravura/projects/microservices/rapport/rapport-asset-pricing.git
11:15:23       =  refs/heads/master:refs/heads/master  [up to date]
11:15:23       Done]
11:15:23     :72c58cfb9dcd0768:commitNewVersion (Thread[Execution worker for ':72c58cfb9dcd0768',5,main]) completed. Took 2.767 secs.
11:15:23     
11:15:23     > Task :release
11:15:23   :release (Thread[Execution worker for ':',5,main]) completed. Took 3 mins 56.162 secs.

in this log, a husky pre-commit hook failed and prevented the commit, but it still continues on to do a no-op push (up to date), and the rest of the release task succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant