diff --git a/CHANGELOG.md b/CHANGELOG.md index ff4e2008a..6fb49b1ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ #### :bug: Bug fix +- Fix: bug where we incorrectly showed a warning notification about something going wrong with incremental type checking, when in fact the compiler was reporting module-related type errors https://github.com/rescript-lang/rescript-vscode/pull/1090 + - Fix: bug where we incorrectly showed a warning notification about something going wrong with incremental type checking, when in fact the compiler was reporting multiple definitions of the same type or module name https://github.com/rescript-lang/rescript-vscode/pull/1086 - Fix: incorrect highlighting of `as` inside labelled arguments like `toast` https://github.com/rescript-lang/rescript-vscode/pull/1085 diff --git a/server/src/incrementalCompilation.ts b/server/src/incrementalCompilation.ts index 0ca5e28d5..2cca64ae8 100644 --- a/server/src/incrementalCompilation.ts +++ b/server/src/incrementalCompilation.ts @@ -683,7 +683,12 @@ async function compileContents( ) || // The `Multiple definition of the name ` type error's // message includes the filepath with LOC of the duplicate definition - d.message.includes("Multiple definition of the") + d.message.startsWith("Multiple definition of the") || + // The signature mismatch, with mismatch and ill typed applicative functor + // type errors all include the filepath with LOC + d.message.startsWith("Signature mismatch") || + d.message.startsWith("In this `with' constraint") || + d.message.startsWith("This `with' constraint on") ) ) { hasIgnoredErrorMessages = true;