Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add python-tasks to examples pixi environment" #7007

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jul 26, 2024

Reverts #6991

pixi run -e examples py-build will NOT do what you want.

Look at the implementation. It runs:

py-build = "pixi run -e py py-build-common"

So it will override your attempt to set the environment by running with a different environment.

This is the entire reason py-build-examples exists.

@jleibs jleibs requested a review from Wumpf July 26, 2024 19:53
@jleibs jleibs marked this pull request as ready for review July 26, 2024 19:53
@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Deployed docs

Commit Link
e90304d https://landing-ciuvl2qod-rerun.vercel.app/docs

@jleibs jleibs added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Jul 26, 2024
@Wumpf
Copy link
Member

Wumpf commented Jul 27, 2024

ah.
But there's a comment in that pixi.toml file that says you're supposed to run pixi run py-build to run examples, that needs to be fixed

@jleibs
Copy link
Member Author

jleibs commented Jul 29, 2024

ah. But there's a comment in that pixi.toml file that says you're supposed to run pixi run py-build to run examples, that needs to be fixed

@Wumpf ok, I'm not seeing anymore obviously wrong docs.

@Wumpf Wumpf merged commit a76daf7 into main Jul 29, 2024
40 checks passed
@Wumpf Wumpf deleted the revert-6991-andreas/fix-missing-py-commands branch July 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants