Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork macaw as re_math; update glam #6856

Closed
wants to merge 15 commits into from
Closed

Fork macaw as re_math; update glam #6856

wants to merge 15 commits into from

Conversation

emilk
Copy link
Member

@emilk emilk commented Jul 11, 2024

What

macaw (which I was one of the main contributors at Embark) is no longer maintained. This is holding us back from updating glam.

macaw was never published as repository anywhere, so I just copied the code from it (it's Apache2/MIT) and modernized it slightly.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added dependencies concerning crates, pip packages etc include in changelog labels Jul 11, 2024
@emilk emilk changed the title Fork macaw as re_math Fork macaw as re_math; update glam Jul 11, 2024
@emilk emilk marked this pull request as ready for review July 11, 2024 09:15
@emilk emilk mentioned this pull request Jul 11, 2024
6 tasks
@Wumpf Wumpf self-requested a review July 11, 2024 13:10
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but the licensing thing can't be right

There's a bunch of things dragged in here where I'm not sure they're actually needed. But admittedly everything looks very useful to have around.

edition.workspace = true
homepage.workspace = true
include.workspace = true
license.workspace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't just apply our own license when it's clearly c&p from a different project to which other people contributed

@emilk
Copy link
Member Author

emilk commented Jul 11, 2024

I'll do this in a separate repo instead, with more proper history and licensing info

@emilk emilk closed this Jul 11, 2024
@emilk
Copy link
Member Author

emilk commented Jul 11, 2024

It's now its own repo instead: https://github.com/rerun-io/re_math

@emilk
Copy link
Member Author

emilk commented Jul 11, 2024

New PR: #6867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update glam and fork macaw
2 participants