-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork macaw
as re_math
; update glam
#6856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but the licensing thing can't be right
There's a bunch of things dragged in here where I'm not sure they're actually needed. But admittedly everything looks very useful to have around.
edition.workspace = true | ||
homepage.workspace = true | ||
include.workspace = true | ||
license.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't just apply our own license when it's clearly c&p from a different project to which other people contributed
I'll do this in a separate repo instead, with more proper history and licensing info |
It's now its own repo instead: https://github.com/rerun-io/re_math |
New PR: #6867 |
What
glam
and forkmacaw
#6467macaw (which I was one of the main contributors at Embark) is no longer maintained. This is holding us back from updating
glam
.macaw
was never published as repository anywhere, so I just copied the code from it (it's Apache2/MIT) and modernized it slightly.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.