Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't truncate ListItem in tooltips #6516

Closed
emilk opened this issue Jun 7, 2024 · 1 comment · Fixed by #6486
Closed

Don't truncate ListItem in tooltips #6516

emilk opened this issue Jun 7, 2024 · 1 comment · Fixed by #6486
Assignees
@emilk
Labels
🪳 bug Something isn't working egui Requires egui/eframe work ui concerns graphical user interface
Milestone
0.17

Comments

@emilk
Copy link
Member

emilk commented Jun 7, 2024 •
edited
Loading

See the last line here:
image

I don't know why it truncates so early, but we should never truncate text when in a tooltip, because the user cannot resize them to see more.

Ongoing work:
@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface egui Requires egui/eframe work labels Jun 7, 2024
@emilk emilk added this to the 0.17 milestone Jun 7, 2024
@emilk emilk changed the title ListItem truncates too early in tooltips Don't truncate ListItem in tooltips Jun 7, 2024
@emilk emilk self-assigned this Jun 10, 2024
@emilk emilk mentioned this issue Jun 10, 2024
Merged
5 tasks
@emilk
Copy link
Member Author

emilk commented Jun 10, 2024

This is quite annoying, but I wouldn't make it a release blocker.

emilk added a commit that referenced this issue Jun 11, 2024
@emilk @abey79
Better integration of ListItem in tooltips and other popups (#6486)
8a46ab7 
### What
* Closes #6516

This PR lets us put any `ListItem` anywhere without trouble.

This is because of two things:
* `ListItem` understands the concept of an egui sizing pass, so won't
expand to become huge when in a tooltip
* `LabelContent` and `PropertyContent` can tell when it is in a tooltip,
and in these cases won't truncate the contents


![image](https://github.com/rerun-io/rerun/assets/1148717/00124975-e8fc-4c4d-aea9-4045d2aed382)


![image](https://github.com/rerun-io/rerun/assets/1148717/b1777695-9188-441d-9eb9-2afede46e0d6)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6486?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6486?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6486)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Antoine Beyeler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working egui Requires egui/eframe work ui concerns graphical user interface
Projects
None yet
Milestone
0.17
Development

Successfully merging a pull request may close this issue.

Better integration of ListItem in tooltips and other popups rerun-io/rerun
1 participant
@emilk