Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal coverage of CSS files #769

Open
jamessspanggg opened this issue Jun 27, 2019 · 4 comments
Open

Minimal coverage of CSS files #769

jamessspanggg opened this issue Jun 27, 2019 · 4 comments
Labels

Comments

@jamessspanggg
Copy link
Contributor

Problem:
When using Coverage tab in Chrome dev tools to analyse the coverage of our CSS and JS files, it is shown that we are utilising vue-loading-spinner.css and mui.min.css in a small percentage.

Screen Shot 2019-06-26 at 11 58 34 PM

Running audits in the Chrome dev tools also shows that there will be potential savings in loading time if we remove both css files.
Screen Shot 2019-06-26 at 11 59 22 PM

Suggestion:
Since we are using only a small part of these two files, let's remove the importing of these files and create our own css classes that achieves the style required.

@Tejas2805
Copy link
Contributor

@jamessspanggg the usage of mui.min.css has increased. Do let me know if you still want me to create our own css class for this style.

Screen Shot 2019-09-24 at 2 49 08 AM

@jamessspanggg
Copy link
Contributor Author

@Tejas2805 it may be better to focus on other issues as this issue may not be as critical.

@Tejas2805
Copy link
Contributor

@jamessspanggg I have already worked on removing the vue-loading-spinner.css. So maybe I will just do a pull request for that for the time being?

@dcshzj dcshzj moved this to Tasks on hold in RepoSense Roadmap Aug 22, 2022
@ckcherry23
Copy link
Member

Related to #1718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Tasks on hold
Development

No branches or pull requests

3 participants