Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit errors for authors with name as display name #713

Open
jamessspanggg opened this issue May 28, 2019 · 2 comments
Open

Commit errors for authors with name as display name #713

jamessspanggg opened this issue May 28, 2019 · 2 comments

Comments

@jamessspanggg
Copy link
Contributor

jamessspanggg commented May 28, 2019

When clicking on ramp slices that are from authors with their name as display name rather than the GitHub user name, it leads to no commits found for this author.

For example, for the author Eugene Peh, all ramp slices link to: No commits found for "Eugene Peh".
Screen Shot 2019-05-28 at 12 07 13 PM
(To replicate, run:
java -jar RepoSense.jar --repo https://github.com/reposense/RepoSense.git -i --view
, search for eugene and set granularity as commit)

Clicking all ramps of Eugene Peh links to this page:
Screen Shot 2019-05-28 at 12 14 22 PM

Furthermore, it is shown in the image above that the author Eugene Peh has a commit "Restore functional test". But in GitHub it shows that it was the author with name eugenepeh that committed instead.
Screen Shot 2019-05-28 at 12 10 24 PM

Lastly, there are repeated ramp slices that refers to the same commit:
Screen Shot 2019-05-28 at 12 41 31 PM
(To replicate, using the same report as above, set since to 28/10/2018 and until to 16/11/2018)

Here's the link to the report

@jamessspanggg jamessspanggg changed the title No commits found for authors with name as display name Commit errors for authors with name as display name May 28, 2019
@fzdy1914
Copy link
Member

fzdy1914 commented May 28, 2019

@jamessspanggg
For further bugs in a self-generated report, please state the command and the version of RepoSense (if it is not latest master) you use to get the report, so we are able to reproduce it when reviewing it.

@fzdy1914
Copy link
Member

fzdy1914 commented May 28, 2019

The error comes from here, we use git author name to be the GitHub id of Author.

But I guess there is no good fix for this. There is not enough information in git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tasks on hold
Development

No branches or pull requests

3 participants