Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show commit details in code view #675

Open
damithc opened this issue May 17, 2019 · 5 comments
Open

Show commit details in code view #675

damithc opened this issue May 17, 2019 · 5 comments

Comments

@damithc
Copy link
Collaborator

damithc commented May 17, 2019

Current: when the user clicks on a ramp, we open the GitHub page showing the commit

Suggested: show the commit in the code view instead

Possibly related: #63

@fzdy1914
Copy link
Member

fzdy1914 commented Dec 9, 2019

Possibly related: #148

@damithc
Copy link
Collaborator Author

damithc commented Mar 3, 2020

@myteo did some exploration on this front. It seems the cost is too high to achieve this, in terms of processing time as well as storage space.

@0blivious
Copy link
Contributor

I found the github API that will return the commit diff, sth like the image below, and there are open source diff parser but havnt tested. If we only make the api query when clicking the ramp I guess the cost might be ok? The problem is we need to import the parser and deal with cors issue.
image

@damithc
Copy link
Collaborator Author

damithc commented Mar 6, 2020

I found the github API that will return the commit diff, sth like the image below, and there are open source diff parser but havnt tested. If we only make the api query when clicking the ramp I guess the cost might be ok? The problem is we need to import the parser and deal with cors issue.

Unauthenticated users have severe API quota limitations though.

@fzdy1914
Copy link
Member

I will leave two related issues here for reference but close them.
Issues are: #63, #148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tasks on hold
Development

No branches or pull requests

3 participants