Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code view: also show image files touched by the user #406

Open
damithc opened this issue Nov 26, 2018 · 2 comments
Open

code view: also show image files touched by the user #406

damithc opened this issue Nov 26, 2018 · 2 comments

Comments

@damithc
Copy link
Collaborator

damithc commented Nov 26, 2018

Suggestion: it is good if we can also show image files that can be attributed to the author e.g., diagrams added

@eugenepeh
Copy link
Member

Hmm one concern about this is that, the users can't annotate the image to claim it as theirs. Hence, the easiest approach would be to credit the image to the last modifier. However, this can cloud the judgement of the reviewer to believe that the entire image was done by the author.

Another approach that I can think of is to create an "image section" under the repository. This image section will purely show the list of images and the corresponding commits that have made changes to it. This would be somewhat similar to the commits view that we were working on previously.

@damithc
Copy link
Collaborator Author

damithc commented Jan 7, 2019

yes, for images we can also list previous authors who modified the file.

@dcshzj dcshzj moved this to Tasks on hold in RepoSense Roadmap Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tasks on hold
Development

No branches or pull requests

2 participants