Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine zoom hashes into single hash using base64 encoding #1195

Open
jamessspanggg opened this issue Mar 29, 2020 · 2 comments
Open

Combine zoom hashes into single hash using base64 encoding #1195

jamessspanggg opened this issue Mar 29, 2020 · 2 comments

Comments

@jamessspanggg
Copy link
Contributor

After this PR, can you put up an issue to combine all the zoom hashes into a single hashes using base64 encoding?
This is to centralize the use of aliases, to limit the appearance of e.g. zU in our code

Originally posted by @eugenepeh in link

With #830 merged, quite a number of zoom hashes are used to restore the zoom tab after reloading. Let's combine them to a single hash using base64 encoding.

@jamessspanggg
Copy link
Contributor Author

@eugenepeh should we do the same for summary as well as authorship? the hash params for these views are increasing as well

@eugenepeh
Copy link
Member

@eugenepeh should we do the same for summary as well as authorship? the hash params for these views are increasing as well

Yes ideally all should be combined into a single base64 encoding, which would then be pre and post processed on every save/reload.

@dcshzj dcshzj moved this to For existing developers in RepoSense Roadmap Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: For developers
Development

No branches or pull requests

2 participants