Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Chart Panel: file type selection #1151

Open
0blivious opened this issue Mar 16, 2020 · 5 comments
Open

Restore Chart Panel: file type selection #1151

0blivious opened this issue Mar 16, 2020 · 5 comments

Comments

@0blivious
Copy link
Contributor

With the new filter by file type feature, file type selection should be encoded in the URL so that a specific file selection can be shared through the URL.

@0blivious 0blivious changed the title Restore Code Panel Restore Chart Panel: file type selection Mar 16, 2020
@Tejas2805 Tejas2805 removed their assignment Jul 21, 2020
@HCY123902
Copy link
Contributor

HCY123902 commented Mar 26, 2021

I think file type selection in chart panel, authorship panel, and zoom panel have already been implemented. However, the current
behavior of the synchronization between the chart panel, authorship panel, and zoom panel does not seem to be consistent.
An example is that when a file type checkbox in the chart panel is unticked, if the authorship panel is open, after reloading, the checkbox in the authorship panel will be unticked but it will not disappear along with the content. However, if this happens to a zoom panel, after reloading, the checkbox will disappear along with the content.

@damithc
Copy link
Collaborator

damithc commented Mar 26, 2021

I don't think there should be any link between the file types of the different panels. If such a syncing is needed, the file types should have been specified in a single place rather than multiple places.
That means file types need to be specified twice in the URL, once for the charts panel and once for the code panel.

@HCY123902
Copy link
Contributor

In that case, will it be necessary to remove the existing synchronization behavior instead?

@damithc
Copy link
Collaborator

damithc commented Mar 26, 2021

In that case, will it be necessary to remove the existing synchronization behavior instead?

Yes, I think so.

@gerhean
Copy link
Contributor

gerhean commented Mar 29, 2021

I think file type selection in chart panel, authorship panel, and zoom panel have already been implemented. However, the current
behavior of the synchronization between the chart panel, authorship panel, and zoom panel does not seem to be consistent.
An example is that when a file type checkbox in the chart panel is unticked, if the authorship panel is open, after reloading, the checkbox in the authorship panel will be unticked but it will not disappear along with the content. However, if this happens to a zoom panel, after reloading, the checkbox will disappear along with the content.

I think this was fixed by #1490

@dcshzj dcshzj moved this to For new contributors in RepoSense Roadmap Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: For contributors
Development

No branches or pull requests

6 participants