Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ramp chart(s) for "virtual authors" #1082

Open
anubh-v opened this issue Feb 15, 2020 · 4 comments
Open

Create ramp chart(s) for "virtual authors" #1082

anubh-v opened this issue Feb 15, 2020 · 4 comments

Comments

@anubh-v
Copy link
Contributor

anubh-v commented Feb 15, 2020

After #823 is fixed, users will be able to disown code by using author tags like
@@author some-randomuser, where some-randomuser is not the git authorname of any author in the AuthorConfiguration.

As discussed in issue 1022, we can add ramp chart(s) for authors like some-randomuser, so that users can easily access all code that has been disowned.

This will also benefit users who meant to claim certain code blocks but made typos in the author tags.

Note: this issue should probably be tackled after #823 is fixed.

@anubh-v
Copy link
Contributor Author

anubh-v commented Mar 1, 2020

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

This decision will influence the implementation for the bugfix in #1067
Prof @damithc, I recall you mentioned that we should adopt the path that takes lesser development effort.

My view is that creating a single ramp chart for all virtual authors will be simpler.
We can create one additional dummy author for each repo (the UNKNOWN_AUTHOR), and credit all disowned code to this author.

@damithc
Copy link
Collaborator

damithc commented Mar 1, 2020

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

Sure. Go ahead.

@eugenepeh
Copy link
Member

eugenepeh commented Mar 1, 2020

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

I would prefer not because that is sort of making //@@author a half baked feature. If it is possible to attribute them as UNKNOWN_AUTHOR then it shouldn't cost much extra code to separate them into individual identities given that the value is already provided together with the tag.

If it would a lot more to implement that change, then its an indication that there's a problem in the underlying structure that should also be fixed.

@anubh-v
Copy link
Contributor Author

anubh-v commented Mar 4, 2020

@eugenepeh, ok, I will implement the bugfix in #1067, with the view that our goal is to have separate ramp charts for virtual authors. I'll discuss with the team in the event that major architecture changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tasks on hold
Development

No branches or pull requests

4 participants