Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1004] Make Authorship Panel consistent with Chart Panel #1064

Closed

Conversation

Tejas2805
Copy link
Contributor

Fixes #1004

@Tejas2805
Copy link
Contributor Author

@damithc What do you think of the Ui?
Based on our discussion, have followed github's style for file-header and made panels white

@damithc
Copy link
Collaborator

damithc commented Feb 9, 2020

GitHub UI has a way to clearly separate each file. We need to have something similar. As of now we have a horizontal line but that seems to separate the filename from the code, rather than showing where a file ends.

image

@Tejas2805
Copy link
Contributor Author

Tejas2805 commented Feb 10, 2020

Screen Shot 2020-02-10 at 8 47 45 AM

@damithc What do you think?

@damithc
Copy link
Collaborator

damithc commented Feb 10, 2020

@damithc What do you think?

As Github does, use a very light grey for the box containing the file name?

@Tejas2805
Copy link
Contributor Author

@damithc I have added the Github colour. I have also suggested two options for borders. Let me know how to proceed.

Screen Shot 2020-02-11 at 2 59 05 AM

Screen Shot 2020-02-11 at 3 21 18 AM

@damithc
Copy link
Collaborator

damithc commented Feb 11, 2020

Option 2 looks better. May be reduce the thickness of the border between the filename and the content as there is no reason for it to be thicker than others?

@Tejas2805
Copy link
Contributor Author

Screen Shot 2020-02-11 at 7 25 22 PM

@damithc For review. Will proceed accordingly then.

@damithc
Copy link
Collaborator

damithc commented Feb 11, 2020

Are you able increase the curvature at the top and bottom corners like this? No curve for the middle one.
image

@Tejas2805
Copy link
Contributor Author

The initial one was 2.

Current top: 4
Current bottom: 8

Screen Shot 2020-02-11 at 8 23 46 PM

@damithc
Copy link
Collaborator

damithc commented Feb 12, 2020

Current top: 4
Current bottom: 8

let's make both 4 as there is no logical reason to make them different.

@Tejas2805
Copy link
Contributor Author

Closing this PR due to some issues. Have re=opened in #1080

@Tejas2805 Tejas2805 closed this Feb 15, 2020
@Tejas2805 Tejas2805 deleted the make-ui-similar-to-github branch February 15, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between Chart Panel and Authorship Panel
2 participants