Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between Chart Panel and Authorship Panel #1004

Open
0blivious opened this issue Jan 18, 2020 · 9 comments
Open

Inconsistency between Chart Panel and Authorship Panel #1004

0blivious opened this issue Jan 18, 2020 · 9 comments
Labels
a-FrontEnd c.Epic

Comments

@0blivious
Copy link
Contributor

The current Chart Panel and Authorship Panel use different font size, color, background color and header height. As suggested by Prof, we can try to make the 2 panels more similar to make the website look more consistent.
@Tejas2805 Tejas2805 self-assigned this Jan 19, 2020
@anubh-v anubh-v added the c.Epic label Jan 23, 2020
This was referenced Feb 8, 2020
Closed
Merged
fzdy1914 pushed a commit that referenced this issue Mar 12, 2020
@Tejas2805
[#1004] Make Code Panel consistent with Chart Panel (#1080)
8eec52d 
The Code Panel and Chart Panel look very different from each other.

Making them be more similar can enhance the user experience.

Let's
- make file title similar to Github's way of displaying
- change background for Code and Commit Panel to white
- change sidebar color to grey
Tejas2805 added a commit to Tejas2805/RepoSense that referenced this issue Mar 13, 2020
@Tejas2805
Merge branch 'refactor-panels-css' of https://github.com/Tejas2805/Re…
af4f816 
…poSense into refactor-panels-css

* 'refactor-panels-css' of https://github.com/Tejas2805/RepoSense:
  [reposense#1109] Config.json: include active author and pug file format (reposense#1123)
  [reposense#1004] Make Code Panel consistent with Chart Panel (reposense#1080)
  [reposense#1005, reposense#1010] Code Panel: match font with GitHub and break lines when overflow (reposense#1008)
  [reposense#1076] Author: add a `isIgnoringFile` method (reposense#1085)
shuiyao-sg pushed a commit to shuiyao-sg/RepoSense that referenced this issue Mar 17, 2020
@Tejas2805 @shuiyao-sg
[reposense#1004] Make Code Panel consistent with Chart Panel (reposen…
3545aea 
…se#1080)

The Code Panel and Chart Panel look very different from each other.

Making them be more similar can enhance the user experience.

Let's
- make file title similar to Github's way of displaying
- change background for Code and Commit Panel to white
- change sidebar color to grey
@Tejas2805
Copy link
Contributor

@damithc Anything else required for this issue?

@damithc
Copy link
Collaborator

damithc commented Mar 24, 2020

I think we can do more. For example, font sizes seems inconsistent between the two panels.
image

Another one: the way groups are shown
image

@Tejas2805
Copy link
Contributor

Will look into it and get back.

@Tejas2805
Copy link
Contributor

Another one: the way groups are shown

@damithc Are you referring to - left panel having color background and the right panel not having it?

@damithc
Copy link
Collaborator

damithc commented Mar 30, 2020

@damithc Are you referring to - left panel having color background and the right panel not having it?

Yes.

@Tejas2805
Copy link
Contributor

Yes.

But will have the color background in the right panel have some use? We are using it in the left panel, to show colors that are being shown in the contribution bar. No such use case in right panel. Should I still go ahead with it ?

@Tejas2805
Copy link
Contributor

Should I still go ahead with it ?

@damithc Need your opinion on it.

@damithc
Copy link
Collaborator

damithc commented Apr 5, 2020

I think we should do it if only for consistency's sake. We might also find some use for it later. e.g., we can use the repeat the file type label for each file to indicate under which file type we consider the file.

@damithc
Copy link
Collaborator

damithc commented Mar 23, 2021

The two look more compatible now, but still feels like designed by different people. e.g., one side has a title while the other side doesn't. More can be done by someone with a good eye for design.

image

@dcshzj dcshzj moved this to For new contributors in RepoSense Roadmap Aug 22, 2022
@ckcherry23 ckcherry23 self-assigned this Mar 6, 2023
@ckcherry23 ckcherry23 mentioned this issue Apr 7, 2023
Merged
dcshzj pushed a commit that referenced this issue Apr 16, 2023
@ckcherry23
[#1004] Standardize fonts for consistency across panels (#1979)
7a58117 
There are inconsistencies in the design between the different panels. 
One aspect that varies is the fonts used in terms of the font sizes and 
families. 

Let us standardize the font sizes across the Vue front-end using mixins.
Let us also set the font family for sans-serif to be Titillium Web and
monospace to be GitHub's default font.
@ckcherry23 ckcherry23 mentioned this issue May 13, 2024
Closed
@ckcherry23 ckcherry23 removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-FrontEnd c.Epic
Projects
RepoSense Roadmap
Status: For contributors
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1004] Make Authorship Panel consistent with Chart Panel Tejas2805/RepoSense
5 participants
@damithc @anubh-v @Tejas2805 @0blivious @ckcherry23