set installer ls response correctly (#182)

Author: jeffreygolden

cli/test/kots_installer_create_test.go

@@ -88,6 +88,14 @@ spec:
 
 			req.Contains(stdout.String(), `SEQUENCE: 2`)
 			req.Contains(stdout.String(), `successfully set to installer 2`)
+
+			rootCmd.SetArgs([]string{"installer", "ls", "--app", app.Slug})
+
+			err = cmd.Execute(rootCmd, nil, &stdout, &stderr)
+			req.NoError(err)
+
+			req.Empty(stderr.String(), "Expected no stderr output")
+			req.NotEmpty(stdout.String(), "Expected stdout output")
 		})
 	})
 

pkg/kotsclient/installer.go

@@ -4,19 +4,29 @@ import (
 	"fmt"
 	"net/http"
 
+	"github.com/pkg/errors"
 	"github.com/replicatedhq/replicated/pkg/types"
+	"github.com/replicatedhq/replicated/pkg/util"
 )
 
 func (c *VendorV3Client) ListInstallers(appID string) ([]types.InstallerSpec, error) {
-	var response []types.InstallerSpec
+	var response types.ListInstallersResponse
 
 	url := fmt.Sprintf("/v3/app/%s/installers", appID)
 	err := c.DoJSON("GET", url, http.StatusOK, nil, &response)
 	if err != nil {
 		return nil, err
 	}
 
-	return response, nil
+	for i, installerSpec := range response.Body {
+		createdAtTime, err := util.ParseTime(installerSpec.CreatedAtString)
+		if err != nil {
+			return nil, errors.Wrap(err, "parsing time string to CreatedAt time")
+		}
+		response.Body[i].CreatedAt = util.Time{createdAtTime}
+	}
+
+	return response.Body, nil
 }
 
 func (c *VendorV3Client) CreateInstaller(appID string, yaml string) (*types.InstallerSpec, error) {

pkg/types/installer.go

@@ -11,13 +11,18 @@ type InstallerSpec struct {
 	YAML            string    `json:"yaml"`
 	ActiveChannels  []Channel `json:"channels"`
 	CreatedAt       util.Time `json:"created"`
+	CreatedAtString string    `json:"createdAt"`
 	Immutable       bool      `json:"isInstallerNotEditable"`
 }
 
 type InstallerSpecResponse struct {
 	Body InstallerSpec `json:"installer"`
 }
 
+type ListInstallersResponse struct {
+	Body []InstallerSpec `json:"installers"`
+}
+
 type CreateInstallerRequest struct {
 	Yaml string `json:"yaml"`
 }