Skip to content

Commit 80de1ee

Browse files
authored
fix(cmx): Use pointer for collect-report bool (#559)
Signed-off-by: Kyle Squizzato <[email protected]>
1 parent 10b82d8 commit 80de1ee

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

cli/cmd/network_update.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func (r *runners) updateNetwork(cmd *cobra.Command, args []string) error {
7171
}
7272

7373
if cmd.Flags().Changed("collect-report") {
74-
opts.CollectReport = r.args.updateNetworkCollectReport
74+
opts.CollectReport = &r.args.updateNetworkCollectReport
7575
}
7676

7777
// Update the network

pkg/kotsclient/network_update.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313

1414
type UpdateNetworkRequest struct {
1515
Policy string `json:"policy"`
16-
CollectReport bool `json:"collect_report"`
16+
CollectReport *bool `json:"collect_report,omitempty"`
1717
}
1818

1919
type UpdateNetworkResponse struct {
@@ -23,7 +23,7 @@ type UpdateNetworkResponse struct {
2323

2424
type UpdateNetworkOpts struct {
2525
Policy string `json:"policy"`
26-
CollectReport bool `json:"collect_report"`
26+
CollectReport *bool `json:"collect_report,omitempty"`
2727
}
2828

2929
type UpdateNetworkErrorResponse struct {
@@ -34,7 +34,10 @@ type UpdateNetworkErrorResponse struct {
3434

3535
// UpdateNetworkPolicy updates a network's policy setting
3636
func (c *VendorV3Client) UpdateNetwork(networkID string, opts UpdateNetworkOpts) (*types.Network, error) {
37-
req := UpdateNetworkRequest(opts)
37+
req := UpdateNetworkRequest{
38+
Policy: opts.Policy,
39+
CollectReport: opts.CollectReport,
40+
}
3841
return c.doUpdateNetworkRequest(networkID, req)
3942
}
4043

0 commit comments

Comments
 (0)