Improve PR body truncation #21669
Replies: 4 comments
-
This is in the continuation of renovatebot/presets#85 (comment).
My suggested behaviour is to extract big changelogs into additional replies and maintain them in case of edits. Create a PR:
Modify a PR:
Now we can also truncate big replies and add a link to the original changelog. |
Beta Was this translation helpful? Give feedback.
-
@pi0 thanks for the ideas. Indeed, expanding the existing PR body to extend it into 1 or more additional "comments" is an alternative to truncating. In fact at one point I had considered whether to move all embedded changelogs out of the main PR body for those who like to merge squash. |
Beta Was this translation helpful? Give feedback.
-
I've also added a small tweak just now to make sure we don't truncate the PR's configuration and footer and instead only truncate the "middle" release notes section. |
Beta Was this translation helpful? Give feedback.
-
Moving changelogs to comments is a good idea, like that. |
Beta Was this translation helpful? Give feedback.
-
If release notes are too long, then we truncate them arbitrarily. Ideally we could do this more cleverly, especially when there are multiple packages in a PR.
Beta Was this translation helpful? Give feedback.
All reactions