Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted everything automatically. Some small fixes. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanwouldgo
Copy link

No description provided.

@renepickhardt
Copy link
Owner

Hey @stefanwouldgo thanks a lot for your effort but I have an issue.

How am I supposed to review this pull request if you changed the formatting? The diff does only depict all the exchanged paragraphs.

Also I desperately had the formatting style of one sentence per line.
In this case git and merging gets not confused when sentences that would usually go over several lines in your formatting get restructured.

so I am a little bit overwhelmed and tempted to decline your PR :( but I don't want to miss the other fixes and hard work from you. Do you have a suggestion how we can 'rescue' your PR?

@renepickhardt
Copy link
Owner

I could also autoformat my current HEAD and then look at your diff but that would force me to change the formatting permantly. Not sure if I want to go with the autoformatted style for the reasons mentioned

@stefanwouldgo
Copy link
Author

Oh damn, that was really stupid of me ;) I just found reading it in emacs cumbersome with your formatting and I didn't see the logic behind it. I tried to reformat it to your standards but it's just too much work for the few enhancements I had put in.

I guess a lot of this will change anyway, so just forget about it. There are just two major corrections that I put in \todo form:

  1. What you wrote about proof-of-work stemming from Hashcash ist not quite correct. Back's Hashcash was just an implementation of the concept of proof-of-work that had been invented by Naor and Dwork: Dwork, Cynthia; Naor, Moni (1993). "Pricing via Processing, Or, Combatting Junk Mail, Advances in Cryptology". CRYPTO’92: Lecture Notes in Computer Science No. 740. Springer: 139–147.
  2. Please learn about proper dashes in LaTeX! The thing you mostly use to insert a thought is spelled --- (triple dash) in LaTeX.

@renepickhardt
Copy link
Owner

Thanks for your understanding I felt really bad when I saw your PR. I will close this later. I will already put your name to the list of contributers even though github won't show this yet. But I am pretty sure this won't be your last PR. Maybe I should also append the README.md stating why formatting is that way and that I won't merge PRs that change the formatting.

@billygarrison
Copy link
Contributor

Maybe I should also append the README.md stating why formatting is that way and that I won't merge PRs that change the formatting.
You could also do a separate CONTRIBUTING.md file perhaps, as I'm sure there will be more issues that come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants