[CHERI_CSA] CapabilityCopyChecker: fix infinite recursion

eupharina · eupharina · commit 2acde833554f · 2023-11-02T12:58:09.000Z
diff --git a/clang/lib/StaticAnalyzer/Checkers/CHERI/CapabilityCopyChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/CHERI/CapabilityCopyChecker.cpp
@@ -124,7 +124,7 @@ const MemRegion *stripNonCapShift(const MemRegion *R, ASTContext &ASTCtx) {
   if (!isNonCapScalarType(ER->getValueType(), ASTCtx))
     return R;
 
-  return ER->getSuperRegion();
+  return stripNonCapShift(ER->getSuperRegion(), ASTCtx);
 }
 
 bool isVoidOrCharPtrArgRegion(const MemRegion *Reg, bool AcceptCharPtr) {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ const MemRegion stripNonCapShift(const MemRegion R, ASTContext &ASTCtx) {`
`124`	`124`	`if (!isNonCapScalarType(ER->getValueType(), ASTCtx))`
`125`	`125`	`return R;`
`126`	`126`
`127`		`- return ER->getSuperRegion();`
	`127`	`+ return stripNonCapShift(ER->getSuperRegion(), ASTCtx);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`bool isVoidOrCharPtrArgRegion(const MemRegion *Reg, bool AcceptCharPtr) {`