Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formally require OAuth client_id to match the origin of the redirect_uri #183

Open
raucao opened this issue Oct 25, 2020 · 0 comments
Open

Comments

@raucao
Copy link
Member

raucao commented Oct 25, 2020

We already decided this to be best practice, and most server implementations require the client ID to match the origin of the redirect URI. However, it is not documented properly, and currently the spec actually says that the client ID should be ignored entirely by the server:

The server MAY expire bearer tokens, and MAY require the user to
register applications as OAuth clients before first use; if no
client registration is required, the server MUST ignore the value of
the client_id parameter in favor of relying on the origin of the
redirect_uri parameter for unique client identification. See section
4 of [Section 4: Origin of a URI"">ORIGIN] for computing the origin.

(Maybe someone can find the conversation where we decided to change this behavior, and then failed to update the spec.)

@jcoglan just ran into this change with an old app of his, which now fails to connect 5apps accounts.

@raucao raucao changed the title Formally require OAuth client_id to match the origin of the redirect_uri Formally require OAuth client_id to match the origin of the redirect_uri Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant