fix(schema): keep custom functions on nested fields (#232)

* fix(schema): fullPath not being constructed properly for nested fields

* fix(schema): functions in modify config get lost during validation

* test: add unit test to assert deep nested field modifications

* fix: move assert to the correct test file

* test: update unit test description

Co-authored-by: Sandrina Pereira <[email protected]>

---------

Co-authored-by: Sandrina Pereira <[email protected]>

Author: nitin-remote

src/modify-schema.ts

@@ -51,7 +51,7 @@ interface ModifyResult {
  * shortToFullPath('foo.bar') // 'foo.properties.bar'
  */
 function shortToFullPath(path: string) {
-  return path.replace('.', '.properties.')
+  return path.replaceAll('.', '.properties.')
 }
 
 /**

src/mutations.ts

@@ -181,10 +181,11 @@ export function updateFieldProperties(fields: Field[], schema: JsfObjectSchema,
       deepMergeSchemas(field, newField)
 
       const fieldSchema = schema.properties?.[field.name]
+      const originalFieldSchema = originalSchema.properties?.[field.name]
 
       if (fieldSchema && typeof fieldSchema === 'object') {
         if (field.fields && fieldSchema.type === 'object') {
-          updateFieldProperties(field.fields, fieldSchema as JsfObjectSchema, originalSchema)
+          updateFieldProperties(field.fields, fieldSchema as JsfObjectSchema, originalFieldSchema as JsfObjectSchema)
         }
       }
     }

test/fields/mutation.test.ts

@@ -439,6 +439,32 @@ describe('field mutation', () => {
         hint: 'Optional contact method',
       })
     })
+
+    it('should be able to preserve x-jsf-presentation properties in a nested field', () => {
+      const customComponent = () => {
+        return null
+      }
+      const schema: JsfObjectSchema = {
+        type: 'object',
+        properties: {
+          apartment: {
+            type: 'object',
+            properties: {
+              number: {
+                'type': 'string',
+                'x-jsf-presentation': {
+                  Component: customComponent,
+                },
+              },
+            },
+          },
+        },
+      }
+      const form = createHeadlessForm(schema)
+      form.handleValidation({ formType: 'advanced' })
+
+      expect(getField(form.fields, 'apartment', 'number')).toHaveProperty('Component', customComponent)
+    })
   })
 
   it('correctly updates required on fields', () => {

test/modify-schema.test.ts

@@ -107,6 +107,17 @@ describe('modifySchema', () => {
           city: {
             title: 'City',
           },
+          apartment: {
+            title: 'House',
+            properties: {
+              floor: {
+                title: 'Floor',
+              },
+              number: {
+                title: 'Number',
+              },
+            },
+          },
         },
       },
     },
@@ -237,6 +248,10 @@ describe('modifySchema', () => {
           'address.city': () => ({
             title: 'City name',
           }),
+          // should be able to handle deep nested fields
+          'address.apartment.number': {
+            title: 'Apartment Number',
+          },
           // Or pass the native object
           'address': (fieldAttrs) => {
             return {
@@ -262,11 +277,21 @@ describe('modifySchema', () => {
               },
               number: {
                 'title': 'Door Number',
-                'x-test-siblings': ['street', 'number', 'city'],
+                'x-test-siblings': ['street', 'number', 'city', 'apartment'],
               },
               city: {
                 title: 'City name',
               },
+              apartment: {
+                properties: {
+                  floor: {
+                    title: 'Floor',
+                  },
+                  number: {
+                    title: 'Apartment Number',
+                  },
+                },
+              },
             },
           },
         },