IE8: Error importing react-router

[jefferyvincent]

Hello,

I have all the required shims to get React 13.0.1 to work in IE8 (console-shim.min, es5-shim.min, es5-sham.min), however once I require react-router I get the following error:

I am using react-hot-loader running webpack-dev-server with the following command:

import { Route } from 'react-router';

[pkese]

Me too

[richfisher]

Me too

[moimikey]

i'm assuming you've tried the non-minified version of es5-sham to see if the error gets thrown unminified? if it does, then you can continue to assume it's es5-sham, if it works unminified, then something went awry during uglification. if it's still the sam having problems, then i'd attribute that to the sham itself and icky support across IE versions :/... the warning in particular you're getting is seemingly only attributed to es5-sham not catching errors it throws and IE 8 doesn't like that explicitly. but that could also be an underlying cause. what triggered the throw in the first place. stack traces help :)

[jefferyvincent]

Yes, here is the results of the non-minified version of es5-sham and your assumptions are correct.

[moimikey]

looks familiar es-shims/es5-shim#297

[pkese]

Is this related #1022 ?

[gitim]

Any updates for this issue?

[jyustman]

@gitim Looks like it'll be fixed in 1.0 #1143 (comment)

[gitim]

Seems that no, because I still have error in ie8

[jyustman]

1.0 hasn't been released yet: #1158

[ryanflorence]

current master (1.0 api) doesn't use getters or Object.defineProperty, so we should be good for IE8

[timdorr]

IE8 and lower no longer work because we switched to Babel 6 and it has a breaking change with those versions: https://phabricator.babeljs.io/T7322