Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types where possible #20

Open
Rezenders opened this issue Oct 3, 2024 · 1 comment
Open

Add types where possible #20

Rezenders opened this issue Oct 3, 2024 · 1 comment
Assignees

Comments

@Rezenders
Copy link
Member

Running the planner with the current pddl formulation for SUAVEsuave takes around 0.5 seconds. I believe this can be improved with a better typing system by adding specialized types for the objects, e.g., fd_recover_thrusters - function_design and so on.

Also, PlanSys is taking very long to solve all the derived predicates (around 30 seconds) due to my poor implementation of supporting existential preconditions and derived predicates. I believe this could be greatly improved if objects and constants had more specialized types that are not subtypes of each other, i.e., part of another type hierarchy.

@tobiaswjohn do you think you could do such modifications the owl->pddl tool?

@tobiaswjohn
Copy link
Collaborator

I think there are two views on this issue:

  1. technically, it is not a big problem to introduce such types. BUT
  2. this results in not interpreting the axioms in the ontology as usual, i.e. we use OWL as a modelling language without using the OWL interpretation. I've seen this a couple of times and I think it makes it really hard for others to understand what we do.

I propose to focus on removing the unnecessary derived predicates (i.e. most of them) first (see issue #19) and see what the difference is before adding more types is a non-owl-conformant way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants