Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unsubscribe function in fetch implementation #10

Open
danielrearden opened this issue Oct 31, 2020 · 0 comments
Open

Return unsubscribe function in fetch implementation #10

danielrearden opened this issue Oct 31, 2020 · 0 comments

Comments

@danielrearden
Copy link

danielrearden commented Oct 31, 2020

Right now, there is no way to unsubscribe. If the context changes (for example, we unmount the component that initialized the query), onNext will continue to be called with additional chunks until the request completes. I think it would make sense for the implementation to return an unsubscribe function that could then be used to cancel the network request. For browsers that support it, we can utilize an AbortController and just call abort inside that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant