Skip to content

Commit b19866c

Browse files
committed
Update instructions on contributing
1 parent 77f551d commit b19866c

File tree

2 files changed

+26
-11
lines changed

2 files changed

+26
-11
lines changed

CONTRIBUTING.org

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ follow them.
1010
- [[#submitting-bugs-and-errors][Submitting Bugs and Errors]]
1111
- [[#submitting-new-code][Submitting New Code]]
1212
- [[#git-commit-messages][Git Commit Messages]]
13+
- [[#create-git-branches][Create Git Branches]]
1314
- [[#describing-the-pull-request][Describing the Pull Request]]
1415
- [[#updating-the-readme][Updating the README]]
16+
- [[#run-your-tests][Run your tests]]
1517
- [[#finding-something-to-do][Finding Something To Do]]
1618
- [[#issue-labels][Issue Labels]]
1719

@@ -57,11 +59,18 @@ especially:
5759
- Use the imperative in your summary
5860
- Use present tense and imperative for what your commit changes
5961

62+
*** Create Git Branches
63+
If you work on a fix or on a new feature, create a new branch prefixed
64+
with ~fix/~ or ~feature/~ respectively and give a descriptive name to your
65+
branch. This simplifies the process of merging PRs for Magit and Forge
66+
users (or for anyone that merge PRs without using Github’s web
67+
interface really).
68+
6069
*** Describing the Pull Request
6170
When opening a new pull request, check that its title is short and
6271
clear as to what you mean it to do. Its description should:
6372
- Provide the current behavior of the package, and how it will modify it
64-
- If it is linked to an open issue, mention it
73+
- If it is linked to an issue, mention it
6574
- If you are submitting an enhancement pull request, describe why this
6675
code suggestion would be useful
6776

@@ -71,6 +80,19 @@ its template, [[file:./README.org.tpl][README.org.tpl]] If you wish to edit it,
7180
rather than the README itself. You don’t need to regenerate it
7281
yourself either.
7382

83+
*** Run your tests
84+
In order to be able to run your tests, make sure [[https://github.com/rejeep/cask.el][Cask]] is available on
85+
your ~$PATH~. You can run the tests with
86+
#+begin_src sh
87+
$ make test
88+
#+end_src
89+
90+
If you push your changes on a branch of the official repo or on your
91+
own Github repo, an automatic CI should check your code is valid not
92+
only for your current version of Emacs but for all versions since
93+
Emacs 25.1. But it doesn’t hurt to check your code works on at least
94+
your version before pushing, you’ll spend less time debugging.
95+
7496
** Finding Something To Do
7597
Not sure where to begin? Take a look at the list of open issues,
7698
especially the ones with one of the following labels:

README.org.tpl

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,9 @@ Or you can just dump ~f.el~ in your load path somewhere.
9494
- [[#using-fel][Using f.el]]
9595
- [[#contribution][Contribution]]
9696

97+
* Contributing
98+
Check [[file:./CONTRIBUTING.org]]
99+
97100
* Documentation and examples
98101
If you have Emacs 28.1 or later, you can access ~f.el~'s shortdoc with
99102
~M-x shortdoc f~. This will essentially give you the examples below save
@@ -991,13 +994,3 @@ Here's an example of a function that finds the Git project root.
991994
#+end_src
992995

993996
Now, try writing it even simpler yourself. Hint, check out ~f-traverse-upwards~.
994-
995-
* Contribution
996-
Be sure to:
997-
- Install [[https://github.com/rejeep/cask.el][Cask]] if you haven’t already
998-
- Run the unit tests with
999-
#+begin_src sh
1000-
$ make test
1001-
#+end_src
1002-
- Do not change ~README.org~ directly. If you want to change the README,
1003-
modify ~README.org.tpl~. The CI will update the actual README itself.

0 commit comments

Comments
 (0)