@@ -10,8 +10,10 @@ follow them.
10
10
- [[#submitting-bugs-and-errors][Submitting Bugs and Errors]]
11
11
- [[#submitting-new-code][Submitting New Code]]
12
12
- [[#git-commit-messages][Git Commit Messages]]
13
+ - [[#create-git-branches][Create Git Branches]]
13
14
- [[#describing-the-pull-request][Describing the Pull Request]]
14
15
- [[#updating-the-readme][Updating the README]]
16
+ - [[#run-your-tests][Run your tests]]
15
17
- [[#finding-something-to-do][Finding Something To Do]]
16
18
- [[#issue-labels][Issue Labels]]
17
19
@@ -57,11 +59,18 @@ especially:
57
59
- Use the imperative in your summary
58
60
- Use present tense and imperative for what your commit changes
59
61
62
+ *** Create Git Branches
63
+ If you work on a fix or on a new feature, create a new branch prefixed
64
+ with ~fix/~ or ~feature/~ respectively and give a descriptive name to your
65
+ branch. This simplifies the process of merging PRs for Magit and Forge
66
+ users (or for anyone that merge PRs without using Github’s web
67
+ interface really).
68
+
60
69
*** Describing the Pull Request
61
70
When opening a new pull request, check that its title is short and
62
71
clear as to what you mean it to do. Its description should:
63
72
- Provide the current behavior of the package, and how it will modify it
64
- - If it is linked to an open issue, mention it
73
+ - If it is linked to an issue, mention it
65
74
- If you are submitting an enhancement pull request, describe why this
66
75
code suggestion would be useful
67
76
@@ -71,6 +80,19 @@ its template, [[file:./README.org.tpl][README.org.tpl]] If you wish to edit it,
71
80
rather than the README itself. You don’t need to regenerate it
72
81
yourself either.
73
82
83
+ *** Run your tests
84
+ In order to be able to run your tests, make sure [[https://github.com/rejeep/cask.el][Cask]] is available on
85
+ your ~$PATH~. You can run the tests with
86
+ #+begin_src sh
87
+ $ make test
88
+ #+end_src
89
+
90
+ If you push your changes on a branch of the official repo or on your
91
+ own Github repo, an automatic CI should check your code is valid not
92
+ only for your current version of Emacs but for all versions since
93
+ Emacs 25.1. But it doesn’t hurt to check your code works on at least
94
+ your version before pushing, you’ll spend less time debugging.
95
+
74
96
** Finding Something To Do
75
97
Not sure where to begin? Take a look at the list of open issues,
76
98
especially the ones with one of the following labels:
0 commit comments