From 6f9bd7306e30866c1afc10797a06586eeb33fbd9 Mon Sep 17 00:00:00 2001
From: Marius Cobzarenco <marius.cobzarenco@uipath.com>
Date: Mon, 27 Feb 2023 11:09:39 +0000
Subject: [PATCH] api: retry conflicts as a workaround

This is a workaround for comment creation / updates conflicting with the `loom`
service that indexes threads objects concurrently. We will be fixing
this properly in the backend, but as a workaround we will retry
conflicts for now.
---
 api/src/retry.rs | 53 +++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 48 insertions(+), 5 deletions(-)

diff --git a/api/src/retry.rs b/api/src/retry.rs
index f29ff7d6..51f87d8a 100644
--- a/api/src/retry.rs
+++ b/api/src/retry.rs
@@ -1,7 +1,9 @@
-use reqwest::{blocking::Response, Result};
-use std::sync::atomic::{AtomicBool, Ordering::SeqCst};
-use std::thread::sleep;
-use std::time::Duration;
+use reqwest::{blocking::Response, Result, StatusCode};
+use std::{
+    sync::atomic::{AtomicBool, Ordering::SeqCst},
+    thread::sleep,
+    time::Duration,
+};
 
 /// Strategy to use if retrying .
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
@@ -60,7 +62,7 @@ impl Retrier {
             }
 
             match send_request() {
-                Ok(response) if response.status().is_server_error() => {
+                Ok(response) if should_retry(&response) => {
                     warn_and_sleep!(format!("{} for {}", response.status(), response.url()))
                 }
                 Err(error) if error.is_timeout() => warn_and_sleep!(error),
@@ -74,6 +76,14 @@ impl Retrier {
     }
 }
 
+fn should_retry(response: &Response) -> bool {
+    // TODO(mcobzarenco): we retry conflicts as a workaround for comment
+    // creation / updates conflicting with the `loom` service that indexes
+    // threads objects concurrently. We will be fixing this properly in the
+    // backend, but as a workaround we will retry conflicts for now.
+    response.status().is_server_error() || response.status() == StatusCode::CONFLICT
+}
+
 #[cfg(test)]
 mod tests {
     use super::{Retrier, RetryConfig, RetryStrategy};
@@ -201,4 +211,37 @@ mod tests {
             .is_timeout());
         timeout.assert();
     }
+
+    #[test]
+    fn test_retry_conflicts() {
+        // TODO(mcobzarenco): we retry conflicts as a workaround for comment
+        // creation / updates conflicting with the `loom` service that indexes
+        // threads objects concurrently. We will be fixing this properly in the
+        // backend, but as a workaround we will retry conflicts for now.
+
+        let mut handler = Retrier::new(RetryConfig {
+            strategy: RetryStrategy::Always,
+            max_retry_count: 5,
+            base_wait: Duration::from_secs(0),
+            backoff_factor: 0.0,
+        });
+        let client = Client::builder().build().unwrap();
+
+        // Retries up to N times on timeout for non-first-requests.
+        for i_retry in 0..10 {
+            let err = mock("POST", "/")
+                .with_status(409)
+                .expect((i_retry + 1).into())
+                .create();
+            handler.config.max_retry_count = i_retry;
+            assert_eq!(
+                handler
+                    .with_retries(|| client.post(format!("http://{}", server_address())).send())
+                    .unwrap()
+                    .status(),
+                409
+            );
+            err.assert();
+        }
+    }
 }