Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-square images should be scaled, not cropped #60

Open
igal opened this issue Dec 20, 2011 · 0 comments
Open

Non-square images should be scaled, not cropped #60

igal opened this issue Dec 20, 2011 · 0 comments

Comments

@igal
Copy link
Collaborator

igal commented Dec 20, 2011

The person that created the http://epdx.org/groups/pdx-se group uploaded a wide image, but Citizenry cropped it to the height of the image, which resulted in all but two letters of the logo being cropped out. He uploaded it multiple times, clearly frustrated and confused by it being cropped.

I worked around this by uploading a square version of the image, which is why it looks okay now -- I simply imported the image into Gimp and expanded the canvas height to match its width, and uploaded the result.

I recommend that we scale non-square images down so they're shown in their entirety, rather than cropping them. I suspect this is a very simple edit to the code handling the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant