Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podspec file should be constant #17

Open
johanblumenberg opened this issue Nov 9, 2022 · 1 comment
Open

Podspec file should be constant #17

johanblumenberg opened this issue Nov 9, 2022 · 1 comment

Comments

@johanblumenberg
Copy link

Description

See this line:

s.source = { :http => 'file:' + __dir__ }

It refers to __dir__, which means that the podspec which is generated on each developers machine will look different, since it contains the full path to the package inside node_modules.
This means that each developer will generate a different Podfile.lock file, since the hash of the Pod will contain the local folder.

Solution

Most other react native packages seem to put the github URL as the source:

  s.source       = { :git => "https://github.com/regulaforensics/react-native-document-reader" }
@johanblumenberg
Copy link
Author

This is a problem also for RNDocumentReaderCore and RNFaceApi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant