Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add checks for ids and resource to useMany #6618

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Dec 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

Added checks for ids and resource props to check in runtime if they are valid or not.

useMany will warn if ids or resource props are missing unless the query is manually enabled through queryOptions.enabled prop.

@aliemir aliemir added this to the January 2025 🎄 milestone Dec 30, 2024
@aliemir aliemir requested a review from a team as a code owner December 30, 2024 13:35
Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: a1df566

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aliemir aliemir changed the base branch from main to next December 30, 2024 13:35
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for refine-doc-live-previews ready!

Name Link
🔨 Latest commit a1df566
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/6772a1a98f9542000858282d
😎 Deploy Preview https://deploy-preview-6618--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 30, 2024

refine    Run #11806

Run Properties:  status check passed Passed #11806  •  git commit 22d426b9dc ℹ️: Merge a1df5664b5e6f692f84bb3bafa4ca793c6addae9 into c45ef1b067879ea820a0fb9b989f...
Project refine
Branch Review fix/core-missing-id-check-in-use-many
Run status status check passed Passed #11806
Run duration 18m 44s
Commit git commit 22d426b9dc ℹ️: Merge a1df5664b5e6f692f84bb3bafa4ca793c6addae9 into c45ef1b067879ea820a0fb9b989f...
Committer Ali Emir Şen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 378
View all changes introduced in this branch ↗︎

@BatuhanW BatuhanW merged commit 5377e7d into next Jan 2, 2025
97 checks passed
@BatuhanW BatuhanW deleted the fix/core-missing-id-check-in-use-many branch January 2, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] useMany throws an error if ids or resource is undefined/not passed
3 participants