Refactor integration tests #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
ppolewicz
reviewed
May 18, 2022
|
|
||
|
|
||
| def test_download_file_by_id_no_auth(raw_api, download_url, file_dict, file_contents): | ||
| def test_download_file_by_id_no_auth(raw_api, download_url, file_dict): |
There was a problem hiding this comment.
file_dict is an unused variable here and in a few more tests. What I think you want to do is a class-based test which inherits from a FileHandlingHelper which uploads a file and assigns it to a self.file_dict in a setUp method
Author
There was a problem hiding this comment.
Why so complicated? I need a file uploaded for the test. I require it in test inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split big test into multiple small ones