Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Incorrect claim regarding /fakeApi/notifications response body #4592

Closed
nanyaDev opened this issue Aug 23, 2023 · 1 comment
Closed

Comments

@nanyaDev
Copy link

In Redux Essentials, Part 6: Performance and Normalizing Data it says:

Our fake API is already sending back the notification entries with isNew and read fields, so we can use those in our code.

The fake API doesn't doesn't actually send back notification entries with those fields. The response body for /fakeApi/notifications has the following shape (taken from my network tab):

[
    {
        "id": "dRlbcYxqEfaHY7--PSjDP",
        "date": "2023-08-23T16:20:17.229Z",
        "message": "is glad we're friends",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    },
    {
        "id": "V35OKeoD09Bgo3KCAWezR",
        "date": "2023-08-23T16:19:22.420Z",
        "message": "sent you a gift",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    },
    {
        "id": "uPCHUku1wC4ZtraWz4tgn",
        "date": "2023-08-23T16:23:40.075Z",
        "message": "poked you",
        "user": "KEsh5ntGEPkFQuJ2faaD5"
    }
]

I've checked the network request, the source code in server.js and even searched the entire repo and there is no mention of those fields.

@nanyaDev nanyaDev changed the title Incorrect information in docs [Docs]Incorrect claim about /fakeApi/notifications response body Aug 23, 2023
@nanyaDev nanyaDev changed the title [Docs]Incorrect claim about /fakeApi/notifications response body [Docs] Incorrect claim about /fakeApi/notifications response body Aug 23, 2023
@nanyaDev nanyaDev changed the title [Docs] Incorrect claim about /fakeApi/notifications response body [Docs] Incorrect claim regarding /fakeApi/notifications response body Aug 23, 2023
@timdorr
Copy link
Member

timdorr commented Aug 23, 2023

Duplicate of reduxjs/redux-essentials-example-app#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants