Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DI overwriting #1

Open
crutchcorn opened this issue Sep 5, 2024 · 5 comments
Open

Add support for DI overwriting #1

crutchcorn opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@crutchcorn
Copy link
Member

In the React and Vue adapters, you can overwrite where the DI comes from in useDispatch and useSelector by passing a context to createDispatchHook (or similarly named)

Let's introduce this functionality to the Angular adapter as well

@crutchcorn crutchcorn added the enhancement New feature or request label Sep 5, 2024
@crutchcorn crutchcorn self-assigned this Sep 5, 2024
@reduxjs reduxjs deleted a comment Sep 5, 2024
@ghost
Copy link

ghost commented Sep 5, 2024

Hi @crutchcorn ✋ can I contribute? It looks promising 👍

@crutchcorn
Copy link
Member Author

Hey @paweltwardziak! I actually think this is going to be a pretty involved effort for this specific feature, but are you at all interested in helping with documentation? I can make some new issues and assign them to you if you are 😄

@ghost
Copy link

ghost commented Sep 5, 2024

Sure thing @crutchcorn :) I am open for any kind of contribution even though it would be great to get involved into something more challenging 👍 ;) Gimme that docs issue 🔥

@nomadts
Copy link

nomadts commented Sep 5, 2024

Hi @crutchcorn
Looks promising 🤩 I also would love to contribute

@crutchcorn
Copy link
Member Author

Love the excitement around the project, thanks y'all!

I'm actually not super sure if I want to do this issue in the end, as it's not as needed due to how Angular's DI system works and allows for overrides in other ways.

I'm gonna close this and open some other tickets that folks can take on. 😄 I'll post them here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants