Skip to content

oracle_cdc: add benchmark suite#4082

Draft
josephwoodward wants to merge 3 commits intomainfrom
jw/oracledb_cdc_benchmark
Draft

oracle_cdc: add benchmark suite#4082
josephwoodward wants to merge 3 commits intomainfrom
jw/oracledb_cdc_benchmark

Conversation

@josephwoodward
Copy link
Contributor

@josephwoodward josephwoodward commented Mar 10, 2026

image

@claude
Copy link

claude bot commented Mar 10, 2026

Commits
LGTM

Review
This PR adds a benchmark suite under internal/impl/oracledb/bench/ with Docker management tasks, Oracle schema setup, data generation scripts, RMAN configuration, and a Redpanda Connect benchmark pipeline config. No Go code changes.

LGTM

@claude
Copy link

claude bot commented Mar 10, 2026

Commits

  1. b1b275boracle_cdc: benchmark — Message is vague and does not use imperative mood. It should describe the action taken (e.g., oracle_cdc: add benchmark data scripts or oracle_cdc: add benchmark config and SQL seed data). If this is a follow-up to 4c066a28 (oracle_cdc: add benchmark suite), consider squashing them into a single commit since they appear to be one logical change.

Review
All changes are benchmark/dev support files (Taskfile, SQL scripts, YAML config, RMAN script) under internal/impl/oracledb/bench/. No Go code changes, no pattern violations, no security issues.

LGTM

@claude
Copy link

claude bot commented Mar 10, 2026

Commits

  1. Commits b1b275b and 5019d3d both have the message oracle_cdc: benchmark — these are vague and identical. Each commit message should describe the specific change it introduces (per commit policy: flag messages that are vague). Consider squashing these into the first commit or giving each a distinct, descriptive message (e.g., oracle_cdc: add benchmark data scripts, oracle_cdc: add benchmark config).

Review
PR adds benchmark tooling (SQL scripts, Taskfile, RMAN config, YAML benchmark config) under internal/impl/oracledb/bench/. No Go code changes, no production code affected.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant