Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for Python 3.8, document that 3.8 or higher is needed and test on >3.8 #67

Open
simonprickett opened this issue Dec 29, 2021 · 0 comments · May be fixed by #68
Open

Remove checks for Python 3.8, document that 3.8 or higher is needed and test on >3.8 #67

simonprickett opened this issue Dec 29, 2021 · 0 comments · May be fixed by #68
Labels
enhancement New feature or request

Comments

@simonprickett
Copy link
Contributor

simonprickett commented Dec 29, 2021 •
edited
Loading

The Makefile currently requires Python 3.8. Remove this hard requirement (probably also the .python-version file) and make sure that the environment builds and tests on Python >=3.8 (e.g. try with 3.9/10/11). Will require update to the README file to say what the minimum version of Python required is.

Removing tests for Python version in favour of documenting the minimum required Python version seems to be a better way to go now.
@simonprickett simonprickett added the enhancement New feature or request label Dec 29, 2021
@simonprickett simonprickett self-assigned this Dec 29, 2021
@simonprickett simonprickett linked a pull request Dec 29, 2021 that will close this issue
Open
@simonprickett simonprickett changed the title Expand Makefile to accept Python 3.9, 3.10 Remove checks for Python 3.8, document that 3.8 or higher is needed and test on >3.8 Feb 10, 2023
@simonprickett simonprickett removed their assignment Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Opened up Makefile to accept newer versions of Python than 3.8 redislabs-training/ru102py
1 participant
@simonprickett