Skip to content

Commit 813d65c

Browse files
[add] Add per test_name sets for visualization: arch, os, branch, deployment_type (#33)
1 parent 489e9df commit 813d65c

File tree

4 files changed

+36
-5
lines changed

4 files changed

+36
-5
lines changed

poetry.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redis-benchmarks-specification"
3-
version = "0.1.7"
3+
version = "0.1.8"
44
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "Readme.md"
@@ -16,7 +16,7 @@ argparse = "^1.4.0"
1616
Flask-HTTPAuth = "^4.4.0"
1717
PyYAML = "^5.4.1"
1818
docker = "^4.4.4"
19-
redisbench-admin = "^0.4.15"
19+
redisbench-admin = "^0.4.16"
2020
psutil = "^5.8.0"
2121
tox-docker = "^3.0.0"
2222

redis_benchmarks_specification/__common__/env.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
DATASINK_RTS_AUTH = os.getenv("DATASINK_RTS_AUTH", None)
5252
DATASINK_RTS_USER = os.getenv("DATASINK_RTS_USER", None)
5353
DATASINK_RTS_HOST = os.getenv("DATASINK_RTS_HOST", "localhost")
54-
DATASINK_RTS_PORT = os.getenv("DATASINK_RTS_PORT", 6379)
54+
DATASINK_RTS_PORT = int(os.getenv("DATASINK_RTS_PORT", "6379"))
5555

5656
# logging related
5757
VERBOSE = os.getenv("VERBOSE", "1") == "0"

utils/tests/test_self_contained_coordinator.py

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,12 +150,24 @@ def test_self_contained_coordinator_blocking_read():
150150
build_variant_setname,
151151
testcases_metric_context_path_setname,
152152
testcases_and_metric_context_path_setname,
153+
project_archs_setname,
154+
project_oss_setname,
155+
project_branches_setname,
156+
project_versions_setname,
157+
project_compilers_setname,
153158
) = get_overall_dashboard_keynames(
154-
tf_github_org, tf_github_repo, tf_triggering_env, test_name
159+
tf_github_org,
160+
tf_github_repo,
161+
tf_triggering_env,
162+
build_variant_name,
163+
running_platform,
164+
test_name,
155165
)
156166
assert rts.redis.exists(testcases_setname)
157167
assert rts.redis.exists(running_platforms_setname)
158168
assert rts.redis.exists(build_variant_setname)
169+
assert rts.redis.exists(testcases_and_metric_context_path_setname)
170+
assert rts.redis.exists(testcases_metric_context_path_setname)
159171
assert build_variant_name.encode() in rts.redis.smembers(
160172
build_variant_setname
161173
)
@@ -179,5 +191,24 @@ def test_self_contained_coordinator_blocking_read():
179191
test_name
180192
]
181193

194+
assert "amd64".encode() in rts.redis.smembers(project_archs_setname)
195+
assert "debian-buster".encode() in rts.redis.smembers(project_oss_setname)
196+
assert "gcc".encode() in rts.redis.smembers(project_compilers_setname)
197+
assert build_variant_name.encode() in rts.redis.smembers(
198+
build_variant_setname
199+
)
200+
assert running_platform.encode() in rts.redis.smembers(
201+
running_platforms_setname
202+
)
203+
204+
assert len(rts.redis.smembers(project_archs_setname)) == 1
205+
assert len(rts.redis.smembers(project_oss_setname)) == 1
206+
assert len(rts.redis.smembers(project_compilers_setname)) == 1
207+
assert len(rts.redis.smembers(build_variant_setname)) == 1
208+
assert len(rts.redis.smembers(running_platforms_setname)) == 1
209+
assert len(rts.redis.smembers(testcases_setname)) == 1
210+
assert len(rts.redis.smembers(project_branches_setname)) == 1
211+
assert len(rts.redis.smembers(project_versions_setname)) == 0
212+
182213
except redis.exceptions.ConnectionError:
183214
pass

0 commit comments

Comments
 (0)