Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests #61

Open
Levi-Leah opened this issue Nov 8, 2021 · 0 comments · May be fixed by #60
Open

Add unittests #61

Levi-Leah opened this issue Nov 8, 2021 · 0 comments · May be fixed by #60
Assignees
@Levi-Leah
Labels
enhancement New feature or request

Comments

@Levi-Leah
Copy link
Collaborator

Levi-Leah commented Nov 8, 2021 •
edited

Add unittests for validation scripts:

  • pcvalidator.py
  • pcchecks.py
  • pcprvalidator.py
  • pcyamlchecks.py
  • pcutil.py

Shared scripts:

  • pcutil.py

And preview scripts:

  • pcbuild.py

Implementation of unittests might trigger a rewrite of some of the scripts (e.g. pcutil.py. we open the yml file 4 times there, we can get away with just returning it, perhaps) and reorg.
@Levi-Leah Levi-Leah added the enhancement New feature or request label Nov 8, 2021
@Levi-Leah Levi-Leah self-assigned this Nov 8, 2021
@Levi-Leah Levi-Leah linked a pull request Nov 8, 2021 that will close this issue
Unittets #60
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Levi-Leah Levi-Leah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unittets redhataccess/pantheon-cmd
1 participant
@Levi-Leah