-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to cleanup multus related options #258
Comments
idea: add "logFile" and "loglevel" in multus.yml.... |
+1, we need a refactor of the Multus options, maybe divide it into a few
categories like -- development (sometimes it's nice to compile it), demos
(sometimes it's nice to set it up in a specific way) and then a way to
install by daemonset -- which it doesn't have yet.
Additionally, the CRDs are out of date for v3.x, too.
…On Wed, Sep 5, 2018, 3:45 AM Tomofumi Hayashi ***@***.***> wrote:
idea: add "logFile" and "loglevel" in multus.yml....
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFN_vRHlUrrEtlBxi38FnD72Rea8uh2Pks5uX4EVgaJpZM4WaWip>
.
|
s1061123
added a commit
to s1061123/kube-ansible
that referenced
this issue
Dec 27, 2018
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings: + rename multus_npwg_demo to multus-2nics + make multus_use_crd default + add multus_build flag (if no/false, use daemonset yaml in github/multus) + unsupport legacy multus version + add docker_install_suppress_newgrp for latest ansible + fix daemonset yaml to support latest k8s + fix several build script (e.g. sr-iov cni) Verified it under following combinations: + pod_network_type=none + pod_network_type=multus + pod_network_type=multus + multus_build=true + pod_network_type=none + multus_build=true + pod_network_type=multus-2nics + pod_network_type=multus-2nics + multus_build=true
s1061123
added a commit
to s1061123/kube-ansible
that referenced
this issue
Dec 27, 2018
To address redhat-nfvpe#245 and redhat-nfvpe#258, this change fixes followings: + rename multus_npwg_demo to multus-2nics + make multus_use_crd default + add multus_build flag (if no/false, use daemonset yaml in github/multus) + unsupport legacy multus version + add docker_install_suppress_newgrp for latest ansible + fix daemonset yaml to support latest k8s + fix several build script (e.g. sr-iov cni) Verified it under following combinations: + pod_network_type=none + pod_network_type=multus + pod_network_type=multus + multus_build=true + pod_network_type=none + multus_build=true + pod_network_type=multus-2nics + pod_network_type=multus-2nics + multus_build=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
multus_use_crd
,multus_npwg_demo
and other multus related options can be cleaned up...The text was updated successfully, but these errors were encountered: