Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio Code Remote Container Support #8

Open
hatmarch opened this issue Jan 21, 2021 · 3 comments
Open

Add Visual Studio Code Remote Container Support #8

hatmarch opened this issue Jan 21, 2021 · 3 comments

Comments

@hatmarch
Copy link
Contributor

In order to make it easier for people to contribute, it would be helpful to codify what is needed to build and run the game components using VS Code Remote Containers and also to add a Contributing.md to the repo that explain this to future contributors.

I've already added most of this anyway (based it off the existing Dockerfile in the repo) so that I can look at and possibly contribute. If you'd like to have it officially in the repo I'm happy to create a pull request with the necessary changes.

@thoraxe
Copy link
Contributor

thoraxe commented Jan 21, 2021

Ya definitely! Currently, I'm building locally but it would be nice to do remote containers (Podman is even supported, so I've heard!).

We currently have an annoying issue in that activemq-cpp isn't available for Fedora 33, but I don't want to build a repo for the RPMs I made for it just to use them for us to just get rid of activemq-cpp in favor of qpid-proton...

But, yes, I agree that remote container would be awesome!

That being said, I wonder if we should also just include various vscode files in the repo as well. For example, I have a cmake debug launch profile...

@hatmarch
Copy link
Contributor Author

Yes adding some tasks/launch configs to the VSCode workspace was part of the plan..trying to make onboarding as easy as possible.

I'll see what I can come up with.

Regarding podman: I've tried to use it before and been disappointed many times. For now I'm just exposing the (Docker Desktop for Mac) docker socket of the host and installing the docker client in the container. We can move that to root(ful or maybe even -less) podman later on.

@hatmarch
Copy link
Contributor Author

hatmarch commented Jan 22, 2021

Have taken a stab at this with PR #9.

It includes default launch and tasks .json for easy building and debugging of the server. It does use Docker (not podman) and has only been tested with VSCode on a Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants