Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong highlighting on 'new' keyword on inner classes #1195

Closed
Meir017 opened this issue Dec 16, 2019 · 3 comments · Fixed by #3224
Closed

Wrong highlighting on 'new' keyword on inner classes #1195

Meir017 opened this issue Dec 16, 2019 · 3 comments · Fixed by #3224

Comments

@Meir017
Copy link

Meir017 commented Dec 16, 2019

creating a new instance of an inner class doesn't highlight the new keyword properly

Environment
  • Operating System: Win10
  • JDK version: 1.8
  • Visual Studio Code version: 1.41
  • Java extension version: 0.54.2
Steps To Reproduce
  1. Create a class and an inner class
// Outer.java
class Outer {
    class Inner {
    }
}

// Program.java
class Program {
    public static void main(String[] args) {
        Outer outer = new Outer();
        Outer.Inner inner = outer.new Inner();
    }
}
Current Result

image

Expected Result

image

@fbricon fbricon changed the title new keywork on inner classes Wrong highlighting on 'new' keyword on inner classes Dec 16, 2019
@fbricon
Copy link
Collaborator

fbricon commented Dec 16, 2019

The textmate grammar is defined in vscode itself, but the source of the grammar is actually atom, so the problem should be reported there: https://github.com/atom/language-java/issues

@Meir017
Copy link
Author

Meir017 commented Dec 16, 2019

sounds similar to atom/language-java#216

@Eskibear
Copy link
Contributor

atom/language-java#216 looks more about the identifiers in new statements, not the new keyword itself. So I just created atom/language-java#228 dedicated for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants