Front end application are badly recognized with the NodeJS/Javascript devfile

[jeffmaury]

/kind bug

What versions of software are you using?

Operating System:
Win10Pro

Output of odo version:

odo v3.0.0-rc2 (39a9a2874)                                 
                                                           
Server: https://api.sandbox.x8i5.p1.openshiftapps.com:6443 
Kubernetes: v1.23.5+012e945                                

How did you run odo exactly?

odo analyze (on https://github.com/quarkusio/quarkus-super-heroes/tree/main/ui-super-heroes)

Actual behavior

Report NodeJS/Javascript instead of Angular/Typescript

Expected behavior

Should report Angular/Typescript

Any logs, error output, etc?

alizer related (see redhat-developer/alizer#105)

[rm3l]

/status blocked

Blocked on this issue on Alizer side: redhat-developer/alizer#105

Once that is done, we'll need to update the Alizer library.

[rm3l]

Now that we have updated Alizer to https://github.com/redhat-developer/alizer/tree/cde3c3fbf451426fd4bdad13a3495519860802ab (which should also include the fix for redhat-developer/alizer#105 (redhat-developer/alizer#106)), I wanted to see if this issue was fixed.

I ran odo analyze on https://github.com/quarkusio/quarkus-super-heroes/tree/main/ui-super-heroes, and now I am getting java-maven (it was indeed reporting nodejs before):

$ odo version --client
odo v3.3.0 (5570f4f19)

$ odo analyze -o json     
[
        {
                "devfile": "java-maven",
                "devfileRegistry": "DefaultDevfileRegistry"
        }
]

@jeffmaury Do you think this is still an issue in Alizer or am I missing something?

[rm3l]

Per the conversation in redhat-developer/alizer#105, it looks like there is an issue in Alizer.

So marking this issue as blocked on redhat-developer/alizer#114

[kadel]

after updating alizer (#6650)

it gets correctly detected as Quarkus

▶ odo analyze -o json
[
	{
		"devfile": "java-quarkus",
		"devfileRegistry": "DefaultDevfileRegistry",
		"ports": [
			8085
		],
		"devfileVersion": "1.3.0"
	}
]

[rm3l]

after updating alizer (#6650)

it gets correctly detected as Quarkus

▶ odo analyze -o json
[
	{
		"devfile": "java-quarkus",
		"devfileRegistry": "DefaultDevfileRegistry",
		"ports": [
			8085
		],
		"devfileVersion": "1.3.0"
	}
]

@kadel I think the issue was more about running odo analyze from ui-super-heroes, which is a sub-folder in quarkus-super-heroes.
With your changes in #6650, we are back to the original situation when this issue was reported: Alizer/odo analyze returns nodejs as the Devfile:

[
  {
    "devfile": "nodejs",
    "devfileRegistry": "ns-devfile-registry",
    "devfileVersion": "2.1.1"
  }
]

But I think this issue is reporting that this is not really accurate, and Alizer/odo analyze should return nodejs-angular instead. And per the discussion in redhat-developer/alizer#105 (comment), the question was about detecting frameworks from the devDependencies list.
So I assume this is not really fixed by #6650 if we want Alizer to detect frameworks from devDependencies.

[github-actions]

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

[github-actions]

This issue was closed because it has been inactive for 30 days since being marked as stale.

[rm3l]

Since quarkusio/quarkus-super-heroes#297, the UI Super-heroes app has become a Quarkus app, which is correctly detected by odo analyze:

☸ ~/w/t/quarkus-super-heroes/ui-super-heroes on  main [!?] via ☕ v21
$ odo analyze -o json
[
        {
                "devfile": "java-quarkus",
                "devfileRegistry": "StagingRegistry",
                "devfileVersion": "1.3.0",
                "name": "ui-super-heroes"
        }
]

Closing this issue for now due to inactivity, but feel free to reopen if needed.
Per redhat-developer/alizer#105 (comment), there is still the issue with making Alizer detect frameworks from devDependencies for projects with a package.json file. But this is an issue for Alizer.