fix checking issues in the when clauses (#189)

ivarmu · web-flow · commit d4b2b80a1ada · 2025-11-20T15:39:56.000-06:00
* fix checking issues in the when clauses

* add changelog fragment
diff --git a/changelogs/fragments/filetree_read_when_issues.yml b/changelogs/fragments/filetree_read_when_issues.yml
@@ -0,0 +1,4 @@
+---
+bugfixes:
+  - Fix checking issues in the when clauses in `filetree_read` role
+...
diff --git a/roles/filetree_create/templates/controller_settings.j2 b/roles/filetree_create/templates/controller_settings.j2
@@ -6,7 +6,7 @@ controller_settings:
 {{ key | indent(width=6, first=True) }}:
 {{ value | to_nice_yaml(indent=2, sort_keys=false) | indent(width=8, first=True) }}
 {%   elif key is match('AUTOMATION_ANALYTICS_LAST_ENTRIES') %}
-{{ key | indent(width=6, first=True) }}: {{ value | from_json }}
+{{ key | indent(width=6, first=True) }}: "{{ value | from_json }}"
 {%   else %}
 {{ key | indent(width=6, first=True) }}: "{{ value | replace('True', 'true') | replace('False', 'false') | replace('None', 'null') }}"
 {%   endif %}
diff --git a/roles/filetree_read/tasks/controller_credential_input_sources.yml b/roles/filetree_read/tasks/controller_credential_input_sources.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_input_sources_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_credential_input_sources.results is defined and __populate_input_sources_list_item.ansible_facts.controller_credential_input_sources is defined
+  when:
+    - __contents_filetree_controller_credential_input_sources is defined
+    - __contents_filetree_controller_credential_input_sources.results is defined
+    - __contents_filetree_controller_credential_input_sources.results | length > 0
+    - __populate_input_sources_list_item.ansible_facts.controller_credential_input_sources is defined
 
 - name: "Set Credential Input Sources Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_credential_types.yml b/roles/filetree_read/tasks/controller_credential_types.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_credentials_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_credential_types.results is defined and __populate_credentials_list_item.ansible_facts.controller_credential_types is defined
+  when:
+    - __contents_filetree_controller_credential_types is defined
+    - __contents_filetree_controller_credential_types.results is defined
+    - __contents_filetree_controller_credential_types.results | length > 0
+    - __populate_credentials_list_item.ansible_facts.controller_credential_types is defined
 
 - name: "Set Projects Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_credentials.yml b/roles/filetree_read/tasks/controller_credentials.yml
@@ -28,7 +28,10 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_credentials.results
+  when:
+    - __contents_filetree_controller_credentials is defined
+    - __contents_filetree_controller_credentials.results is defined
+    - __contents_filetree_controller_credentials.results | length > 0
 
 - name: "Segregated Credentials list when controller_location is defined"
   when: controller_location is defined and __populate_controller_credentials is defined
diff --git a/roles/filetree_read/tasks/controller_execution_environments.yml b/roles/filetree_read/tasks/controller_execution_environments.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_execution_environments_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_execution_environments.results is defined and __populate_execution_environments_list_item.ansible_facts.controller_execution_environments is defined
+  when:
+    - __contents_filetree_controller_execution_environments is defined
+    - __contents_filetree_controller_execution_environments.results is defined
+    - __contents_filetree_controller_execution_environments.results | length > 0
+    - __populate_execution_environments_list_item.ansible_facts.controller_execution_environments is defined
 
 - name: "Segregated Execution Environments list when controller_location is defined"
   when: controller_location is defined and __populate_controller_execution_environments is defined
diff --git a/roles/filetree_read/tasks/controller_host_groups.yml b/roles/filetree_read/tasks/controller_host_groups.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_groups_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_groups.results is defined and __populate_groups_list_item.ansible_facts.controller_groups is defined
+  when:
+    - __contents_filetree_controller_groups is defined
+    - __contents_filetree_controller_groups.results is defined
+    - __contents_filetree_controller_groups.results | length > 0
+    - __populate_groups_list_item.ansible_facts.controller_groups is defined
 
 - name: "Set Groups Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_hosts.yml b/roles/filetree_read/tasks/controller_hosts.yml
@@ -28,7 +28,10 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_hosts.results
+  when:
+    - __contents_filetree_controller_hosts is defined
+    - __contents_filetree_controller_hosts.results is defined
+    - __contents_filetree_controller_hosts.results | length > 0
 
 - name: "Segregated Hosts list when controller_location is defined"
   when: controller_location is defined and __populate_controller_hosts is defined
diff --git a/roles/filetree_read/tasks/controller_instance_groups.yml b/roles/filetree_read/tasks/controller_instance_groups.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_instance_groups_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_instance_groups.results is defined and __populate_instance_groups_list_item.ansible_facts.controller_instance_groups is defined
+  when:
+    - __contents_filetree_controller_instance_groups is defined
+    - __contents_filetree_controller_instance_groups.results is defined
+    - __contents_filetree_controller_instance_groups.results | length > 0
+    - __populate_instance_groups_list_item.ansible_facts.controller_instance_groups is defined
 
 - name: "Segregated Instance Groups list when controller_location is defined"
   when: controller_location is defined and __populate_controller_instance_groups is defined
diff --git a/roles/filetree_read/tasks/controller_inventories.yml b/roles/filetree_read/tasks/controller_inventories.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_inventories.results
+  when:
+    - __contents_filetree_controller_inventories is defined
+    - __contents_filetree_controller_inventories.results is defined
+    - __contents_filetree_controller_inventories.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/controller_inventory_sources.yml b/roles/filetree_read/tasks/controller_inventory_sources.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_inventory_sources_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_inventory_sources.results is defined and __populate_inventory_sources_list_item.ansible_facts.controller_inventory_sources is defined
+  when:
+    - __contents_filetree_controller_inventory_sources is defined
+    - __contents_filetree_controller_inventory_sources.results is defined
+    - __contents_filetree_controller_inventory_sources.results | length > 0
+    - __populate_inventory_sources_list_item.ansible_facts.controller_inventory_sources is defined
 
 - name: "Segregated Inventory Sources list when controller_location is defined"
   when: controller_location is defined and __populate_controller_inventory_sources is defined
diff --git a/roles/filetree_read/tasks/controller_job_templates.yml b/roles/filetree_read/tasks/controller_job_templates.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_templates.results
+  when:
+    - __contents_filetree_controller_templates is defined
+    - __contents_filetree_controller_templates.results is defined
+    - __contents_filetree_controller_templates.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/controller_labels.yml b/roles/filetree_read/tasks/controller_labels.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_labels_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_labels.results is defined and __populate_labels_list_item.ansible_facts.controller_labels is defined
+  when:
+    - __contents_filetree_controller_labels is defined
+    - __contents_filetree_controller_labels.results is defined
+    - __contents_filetree_controller_labels.results | length > 0
+    - __populate_labels_list_item.ansible_facts.controller_labels is defined
 
 - name: "Set Labels Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_notification_templates.yml b/roles/filetree_read/tasks/controller_notification_templates.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_notifications_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_notifications.results is defined and __populate_notifications_list_item.ansible_facts.controller_notifications is defined
+  when:
+    - __contents_filetree_controller_notifications is defined
+    - __contents_filetree_controller_notifications.results is defined
+    - __contents_filetree_controller_notifications.results | length > 0
+    - __populate_notifications_list_item.ansible_facts.controller_notifications is defined
 
 - name: "Set Notifications Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_projects.yml b/roles/filetree_read/tasks/controller_projects.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_projects.results
+  when:
+    - __contents_filetree_controller_projects is defined
+    - __contents_filetree_controller_projects.results is defined
+    - __contents_filetree_controller_projects.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/controller_roles.yml b/roles/filetree_read/tasks/controller_roles.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_roles.results
+  when:
+    - __contents_filetree_controller_roles is defined
+    - __contents_filetree_controller_roles.results is defined
+    - __contents_filetree_controller_roles.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/controller_schedules.yml b/roles/filetree_read/tasks/controller_schedules.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_schedules_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_schedules.results is defined and __populate_schedules_list_item.ansible_facts.controller_schedules is defined
+  when:
+    - __contents_filetree_controller_schedules is defined
+    - __contents_filetree_controller_schedules.results is defined
+    - __contents_filetree_controller_schedules.results | length > 0
+    - __populate_schedules_list_item.ansible_facts.controller_schedules is defined
 
 - name: "Set Schedules Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/controller_settings.yml b/roles/filetree_read/tasks/controller_settings.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_settings_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_settings.results is defined and __populate_settings_list_item.ansible_facts.controller_settings is defined
+  when:
+    - __contents_filetree_controller_settings is defined
+    - __contents_filetree_controller_settings.results is defined
+    - __contents_filetree_controller_settings.results | length > 0
+    - __populate_settings_list_item.ansible_facts.controller_settings is defined
 
 - name: "Segregated Settings list when controller_location is defined"
   when: controller_location is defined and __populate_controller_settings is defined
diff --git a/roles/filetree_read/tasks/controller_workflow_job_templates.yml b/roles/filetree_read/tasks/controller_workflow_job_templates.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_controller_workflow_job_templates.results
+  when:
+    - __contents_filetree_controller_workflow_job_templates is defined
+    - __contents_filetree_controller_workflow_job_templates.results is defined
+    - __contents_filetree_controller_workflow_job_templates.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_applications.yml b/roles/filetree_read/tasks/gateway_applications.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_applications_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_aap_applications.results is defined and __populate_applications_list_item.ansible_facts.aap_applications is defined
+  when:
+    - __contents_filetree_aap_applications is defined
+    - __contents_filetree_aap_applications.results is defined
+    - __contents_filetree_aap_applications.results | length > 0
+    - __populate_applications_list_item.ansible_facts.aap_applications is defined
 
 - name: "Set Applications Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/gateway_authenticator_maps.yml b/roles/filetree_read/tasks/gateway_authenticator_maps.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_authenticator_maps.results
+  when:
+    - __contents_filetree_gateway_authenticator_maps is defined
+    - __contents_filetree_gateway_authenticator_maps.results is defined
+    - __contents_filetree_gateway_authenticator_maps.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_authenticators.yml b/roles/filetree_read/tasks/gateway_authenticators.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_authenticators.results
+  when:
+    - __contents_filetree_gateway_authenticators is defined
+    - __contents_filetree_gateway_authenticators.results is defined
+    - __contents_filetree_gateway_authenticators.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_http_ports.yml b/roles/filetree_read/tasks/gateway_http_ports.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_http_ports.results
+  when:
+    - __contents_filetree_gateway_http_ports is defined
+    - __contents_filetree_gateway_http_ports.results is defined
+    - __contents_filetree_gateway_http_ports.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_organizations.yml b/roles/filetree_read/tasks/gateway_organizations.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_organizations_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_aap_organizations.results is defined and __populate_organizations_list_item.ansible_facts.aap_organizations is defined
+  when:
+    - __contents_filetree_aap_organizations is defined
+    - __contents_filetree_aap_organizations.results is defined
+    - __contents_filetree_aap_organizations.results | length > 0
+    - __populate_organizations_list_item.ansible_facts.aap_organizations is defined
 
 - name: "Set Organization Data Structure"
   ansible.builtin.set_fact:
diff --git a/roles/filetree_read/tasks/gateway_role_definitions.yml b/roles/filetree_read/tasks/gateway_role_definitions.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_role_definitions.results
+  when:
+    - __contents_filetree_gateway_role_definitions is defined
+    - __contents_filetree_gateway_role_definitions.results is defined
+    - __contents_filetree_gateway_role_definitions.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_role_team_assignments.yml b/roles/filetree_read/tasks/gateway_role_team_assignments.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_role_team_assignments.results
+  when:
+    - __contents_filetree_gateway_role_team_assignments is defined
+    - __contents_filetree_gateway_role_team_assignments.results is defined
+    - __contents_filetree_gateway_role_team_assignments.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_role_user_assignments.yml b/roles/filetree_read/tasks/gateway_role_user_assignments.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_role_user_assignments.results
+  when:
+    - __contents_filetree_gateway_role_user_assignments is defined
+    - __contents_filetree_gateway_role_user_assignments.results is defined
+    - __contents_filetree_gateway_role_user_assignments.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_routes.yml b/roles/filetree_read/tasks/gateway_routes.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_routes.results
+  when:
+    - __contents_filetree_gateway_routes is defined
+    - __contents_filetree_gateway_routes.results is defined
+    - __contents_filetree_gateway_routes.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_service_clusters.yml b/roles/filetree_read/tasks/gateway_service_clusters.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_service_clusters.results
+  when:
+    - __contents_filetree_gateway_service_clusters is defined
+    - __contents_filetree_gateway_service_clusters.results is defined
+    - __contents_filetree_gateway_service_clusters.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_service_keys.yml b/roles/filetree_read/tasks/gateway_service_keys.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_service_keys.results
+  when:
+    - __contents_filetree_gateway_service_keys is defined
+    - __contents_filetree_gateway_service_keys.results is defined
+    - __contents_filetree_gateway_service_keys.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_service_nodes.yml b/roles/filetree_read/tasks/gateway_service_nodes.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_service_nodes.results
+  when:
+    - __contents_filetree_gateway_service_nodes is defined
+    - __contents_filetree_gateway_service_nodes.results is defined
+    - __contents_filetree_gateway_service_nodes.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_services.yml b/roles/filetree_read/tasks/gateway_services.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_services.results
+  when:
+    - __contents_filetree_gateway_services is defined
+    - __contents_filetree_gateway_services.results is defined
+    - __contents_filetree_gateway_services.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_settings.yml b/roles/filetree_read/tasks/gateway_settings.yml
@@ -28,5 +28,8 @@
         combine
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_gateway_settings.results
+  when:
+    - __contents_filetree_gateway_settings is defined
+    - __contents_filetree_gateway_settings.results is defined
+    - __contents_filetree_gateway_settings.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_teams.yml b/roles/filetree_read/tasks/gateway_teams.yml
@@ -28,5 +28,8 @@
         ansible.builtin.flatten
       }}
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_aap_teams.results
+  when:
+    - __contents_filetree_aap_teams is defined
+    - __contents_filetree_aap_teams.results is defined
+    - __contents_filetree_aap_teams.results | length > 0
 ...
diff --git a/roles/filetree_read/tasks/gateway_users.yml b/roles/filetree_read/tasks/gateway_users.yml
@@ -25,7 +25,11 @@
   loop_control:
     loop_var: __populate_user_accounts_list_item
   no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
-  when: __contents_filetree_aap_user_accounts.results is defined and __populate_user_accounts_list_item.ansible_facts.aap_user_accounts is defined
+  when:
+    - __contents_filetree_aap_user_accounts is defined
+    - __contents_filetree_aap_user_accounts.results is defined
+    - __contents_filetree_aap_user_accounts.results | length > 0
+    - __populate_user_accounts_list_item.ansible_facts.aap_user_accounts is defined
 
 - name: "Set User Accounts Data Structure"
   ansible.builtin.set_fact:

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +bugfixes:
 +  - Fix checking issues in the when clauses in `filetree_read` role
 +...