Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration date to "commit tags" on quay #397

Closed
mgoerens opened this issue Aug 3, 2023 · 1 comment · Fixed by #402
Closed

Add expiration date to "commit tags" on quay #397

mgoerens opened this issue Aug 3, 2023 · 1 comment · Fixed by #402
Assignees

Comments

@mgoerens
Copy link
Contributor

mgoerens commented Aug 3, 2023

Since #386 we push one new tag to Quay.io per commit on the main branch. This creates a lot of new tags, that we probably won't really need down the road.

Some numbers of https://quay.io/repository/redhat-certification/chart-verifier?tab=tags:

image

At this rhythm, we're going to have hundreds of "commit tags" in just a few months.

This is a suggestion to add an expiration to those images. See https://docs.projectquay.io/use_quay.html#tag-expiration

Maybe 1 month is enough ?

@mgoerens mgoerens self-assigned this Aug 3, 2023
@mgoerens
Copy link
Contributor Author

mgoerens commented Aug 3, 2023

Agreed on using 7 days for tag expiration

mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Aug 3, 2023
Prior to podman 4.6.0, there is a bug that would cause the expiration
tag to be added to the "main" container image as well in the build.yaml
workflow. See the buildah bug report:
containers/buildah#4632

As a workaround, the --no-cache flag is used to build container images
with the "build-image" make target.

This workaround, can be removed when we use a runner image that has
podman>=4.6.0. Currently, the ubuntu-latest runner image we use has
3.4.4.

close redhat-certification#397

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Aug 4, 2023
Prior to podman 4.6.0, there is a bug that would cause the expiration
tag to be added to the "main" container image as well in the build.yaml
workflow. See the buildah bug report:
containers/buildah#4632

As a workaround, the --no-cache flag is used to build container images
with the "build-image" make target.

This workaround, can be removed when we use a runner image that has
podman>=4.6.0. Currently, the ubuntu-latest runner image we use has
3.4.4.

close redhat-certification#397

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Aug 8, 2023
Prior to podman 4.6.0, there is a bug that would cause the expiration
tag to be added to the "main" container image as well in the main.yaml
workflow. See the buildah bug report:
containers/buildah#4632

As a workaround, the --no-cache flag is used to build container images
with the "build-image" make target.

This workaround, can be removed when we use a runner image that has
podman>=4.6.0. Currently, the ubuntu-latest runner image is currently
based on Ubuntu 22.04 and had podman 3.4.4.

close redhat-certification#397

Signed-off-by: mgoerens <[email protected]>
komish pushed a commit that referenced this issue Aug 8, 2023
Prior to podman 4.6.0, there is a bug that would cause the expiration
tag to be added to the "main" container image as well in the main.yaml
workflow. See the buildah bug report:
containers/buildah#4632

As a workaround, the --no-cache flag is used to build container images
with the "build-image" make target.

This workaround, can be removed when we use a runner image that has
podman>=4.6.0. Currently, the ubuntu-latest runner image is currently
based on Ubuntu 22.04 and had podman 3.4.4.

close #397

Signed-off-by: mgoerens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant