-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure dev release workflow to use podman #391
Comments
@mgoerens Indeed. For tag management, I generally like the references to be the same (i.e. shuffling tags around). For context, the only reason we maintain a 0.1.0 release is because it allows for the openshift-tools-installer to install the latest version of chart-verifier. I believe it actually uses the GitHub release, not the container image, but the image is pushed to keep things consistent. |
This was actually tackled in #378 where the dev_release workflow was updated to use the |
Do you suggest merging "main.yaml" and "dev_release.yaml" workflows ? |
@mgoerens thanks for correcting the record here to make sure things tie back to the right places.
I don't like the idea of merging the two workflows, but I do want to see the images be fundamentally the same underlying digests. The easy way to do this would be to remove the image-publishing component for dev_release and just tag 0.1.0 when we build the main image. This could also be re-architected some way to separate concerns, but I'll leave that open to whatever you like. |
close redhat-certification#391 Signed-off-by: mgoerens <[email protected]>
close redhat-certification#391 Signed-off-by: mgoerens <[email protected]>
close #391 Signed-off-by: mgoerens <[email protected]>
https://github.com/redhat-certification/chart-verifier/blob/main/.github/workflows/dev_release.yaml
In #386 we reconfigured our image building workflow to leverage podman. The dev release was configured to use the scripts that leveraged the docker API in order to match the main workflow. Since that's now changed, the dev release can probably be updated accordingly.
As a secondary item, the dev release
0.1.0
and themain
image tags are built on the same triggers, but are built at different times. It may make sense to work these two things together such that they're the same underlying image.The text was updated successfully, but these errors were encountered: