Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit information to version output of chart-verifier #362

Closed
komish opened this issue Jun 29, 2023 · 2 comments · Fixed by #370
Closed

Add commit information to version output of chart-verifier #362

komish opened this issue Jun 29, 2023 · 2 comments · Fixed by #370
Assignees
@mgoerens

Comments

@komish
Copy link
Contributor

komish commented Jun 29, 2023

This is a useful breadcrumb to identify exactly what commit was used to build a given version. Specifically useful for the dev release.
@mgoerens
Copy link
Contributor

mgoerens commented Jul 7, 2023

@komish Could you please assign this issue to me ?

@komish
Copy link
Contributor Author

komish commented Jul 7, 2023

Done @mgoerens. At a minimum, I just want the commit used to build this to be injected at binary build time. Like what you might see from git rev-parse head.

What may also be interesting is a modified for the version subcommand that spits this, as well as the version string out as a data blob. Something like chart-verifier version --as-data spitting out

{ "version": "1.12.0", "commit": "aaaaaabbbbbbcccccc"}

The latter idea isn't a hard requirement. Thanks for taking a look!

mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 10, 2023
@mgoerens
Add commit ID to version output
65d9898 
- add a "build" make target, which injects the git commit ID using
  ldflags
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 10, 2023
@mgoerens
Add commit ID to version output
1cb9515 
- add a "build" make target, which injects the git commit ID using
  ldflags
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
@komish komish linked a pull request Jul 10, 2023 that will close this issue
Add commit ID to version output #370
Merged
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 10, 2023
@mgoerens
Add commit ID to version output
7bd9203 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 11, 2023
@mgoerens
Add commit ID to version output
2f3418b 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 11, 2023
@mgoerens
Add commit ID to version output
49f0189 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 11, 2023
@mgoerens
Add commit ID to version output
a5cea56 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 11, 2023
@mgoerens
Add commit ID to version output
5adbf80 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 11, 2023
@mgoerens
Add commit ID to version output
5c418c5 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 13, 2023
@mgoerens
Add commit ID to version output
871ca90 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 13, 2023
@mgoerens
Add commit ID to version output
78f0af3 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 13, 2023
@mgoerens
Add commit ID to version output
afe8b20 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 17, 2023
@mgoerens
Add commit ID to version output
4dcd90a 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 17, 2023
@mgoerens
Add commit ID to version output
4d8a725 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target
- fix path to chart used to test the built docker image in buildandtest
  script (moved as part of !271) and make use of the JSON output

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
mgoerens added a commit to mgoerens/chart-verifier that referenced this issue Jul 18, 2023
@mgoerens
Add commit ID to version output
e73878a 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target
- fix path to chart used to test the built docker image in buildandtest
  script (moved as part of !271) and make use of the JSON output

close redhat-certification#362

Signed-off-by: mgoerens <[email protected]>
komish pushed a commit that referenced this issue Jul 18, 2023
@mgoerens @komish
Add commit ID to version output
40ba87f 
- use ldflags to injects the git commit ID at build time
- add the commit ID to the version output
- add the possibility to get the version and commit information in a
  JSON format
- adapt the tests to make use of the JSON output
- adapt Dockerfile to make use of the make bin target
- fix path to chart used to test the built docker image in buildandtest
  script (moved as part of !271) and make use of the JSON output

close #362

Signed-off-by: mgoerens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgoerens mgoerens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add commit ID to version output mgoerens/chart-verifier
2 participants
@mgoerens @komish